linux-kernel - Re: [PATCH v4 11/16] drm/msm/dpu: split PIPES_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vyc6zvymcaaw7nlkrsmxwrpbh5u7znl3pyegex6xndz3ibmm3w@xdm7lxlibkvp>
Date: Thu, 16 Jan 2025 10:04:15 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jun Nie <jun.nie@...aro.org>
Cc: Rob Clark <robdclark@...il.com>, 
	Abhinav Kumar <quic_abhinavk@...cinc.com>, Sean Paul <sean@...rly.run>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 11/16] drm/msm/dpu: split PIPES_PER_STAGE definition
 per plane and mixer

On Thu, Jan 16, 2025 at 03:26:00PM +0800, Jun Nie wrote:
> Split the PIPES_PER_STAGE definition per plane and mixer pair.

Why are you trying to repeat commit subject? I noticed this pattern in
other patches too.

> Currently, 2 pipes are supported for a plane at most. A stage struct
> contains configuration for a mixer pair, so pipes per stage are
> identical to pipes per plane in this case. More pipes will be required
> for the quad-pipe case in the future, and pipes per stage will be
> different from pipes per plane in this case. So pipes per plane is
> split out as PIPES_PER_PLANE.

The stage contains configuration for a mixer pair. Currently the plane
supports just one stage and 2 pipes. Quad-pipe support will require
handling 2 stages and 4 pipes at the same time. In preparation for that
add a separate define, PIPES_PER_PLANE, to denote number of pipes that
can be used by the plane.

With that being used as a commit message:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

Please use this as an example of what is expected from the commit
messages.

-- 
With best wishes
Dmitry