linux-kernel - Re: [PATCH] zram: cleanup in zram_read_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <iiiqdmxebni4sfal7rguy4me24tgmzym2v4oz5hzjv624vavr6@kida3yjmoecs>
Date: Thu, 16 Jan 2025 09:41:34 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Wenchao Hao <haowenchao22@...il.com>
Cc: Minchan Kim <minchan@...nel.org>, 
	Sergey Senozhatsky <senozhatsky@...omium.org>, Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org, 
	linux-block@...r.kernel.org
Subject: Re: [PATCH] zram: cleanup in zram_read_from_zspool()

On (25/01/15 22:55), Wenchao Hao wrote:
> @@ -1561,11 +1561,6 @@ static int zram_read_from_zspool(struct zram *zram, struct page *page,
>  
>  	size = zram_get_obj_size(zram, index);
>  
> -	if (size != PAGE_SIZE) {
> -		prio = zram_get_priority(zram, index);
> -		zstrm = zcomp_stream_get(zram->comps[prio]);
> -	}
> -
>  	src = zs_map_object(zram->mem_pool, handle, ZS_MM_RO);
>  	if (size == PAGE_SIZE) {
>  		dst = kmap_local_page(page);
> @@ -1573,6 +1568,9 @@ static int zram_read_from_zspool(struct zram *zram, struct page *page,
>  		kunmap_local(dst);
>  		ret = 0;
>  	} else {
> +		prio = zram_get_priority(zram, index);
> +		zstrm = zcomp_stream_get(zram->comps[prio]);
> +
>  		dst = kmap_local_page(page);
>  		ret = zcomp_decompress(zram->comps[prio], zstrm,
>  				       src, size, dst);

I think you are looking at some old code base (or maybe vanilla kernel),
that function does not look like this in the current mm tree (or linux-next).