linux-kernel - RE: [PATCH] platform/mellanox: mlxreg-io: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH7PR12MB6668DFB042D73A37C7EC6C6BAF1A2@PH7PR12MB6668.namprd12.prod.outlook.com>
Date: Thu, 16 Jan 2025 09:03:51 +0000
From: Vadim Pasternak <vadimp@...dia.com>
To: Ai Chao <aichao@...inos.cn>, "hdegoede@...hat.com" <hdegoede@...hat.com>,
	"ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] platform/mellanox: mlxreg-io: use sysfs_emit() instead of
 sprintf()



> -----Original Message-----
> From: Ai Chao <aichao@...inos.cn>
> Sent: Thursday, 16 January 2025 10:11
> To: hdegoede@...hat.com; ilpo.jarvinen@...ux.intel.com; Vadim Pasternak
> <vadimp@...dia.com>; platform-driver-x86@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Ai Chao <aichao@...inos.cn>
> Subject: [PATCH] platform/mellanox: mlxreg-io: use sysfs_emit() instead of
> sprintf()
> 
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: Ai Chao <aichao@...inos.cn>

Acked-by: Vadim Pasternak <vadimp@...dia.com>

> ---
>  drivers/platform/mellanox/mlxreg-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mellanox/mlxreg-io.c
> b/drivers/platform/mellanox/mlxreg-io.c
> index 595276206baf..97fefe6c38d1 100644
> --- a/drivers/platform/mellanox/mlxreg-io.c
> +++ b/drivers/platform/mellanox/mlxreg-io.c
> @@ -126,7 +126,7 @@ mlxreg_io_attr_show(struct device *dev, struct
> device_attribute *attr,
> 
>  	mutex_unlock(&priv->io_lock);
> 
> -	return sprintf(buf, "%u\n", regval);
> +	return sysfs_emit(buf, "%u\n", regval);
> 
>  access_error:
>  	mutex_unlock(&priv->io_lock);
> --
> 2.47.1