linux-kernel - Re: [PATCH v1] serial: sc16is7xx: Extend IRQ check for negative valus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be1bc254-da95-47c2-b81c-e630c0f924b2@kernel.org>
Date: Thu, 16 Jan 2025 10:42:14 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Andre Werner <andre.werner@...tec-electronic.com>,
 gregkh@...uxfoundation.org, hvilleneuve@...onoff.com, andy@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 lech.perczak@...lingroup.com
Subject: Re: [PATCH v1] serial: sc16is7xx: Extend IRQ check for negative valus

This is threaded weirdly.

On 16. 01. 25, 10:32, Andre Werner wrote:
> Fix the IRQ check to treat the negative values as No IRQ.

Care to describe on what HW that can happen?

> Signed-off-by: Andre Werner <andre.werner@...tec-electronic.com>
> ---
>   drivers/tty/serial/sc16is7xx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 7b51cdc274fd..560f45ed19ae 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1561,7 +1561,7 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype,
>   	/* Always ask for fixed clock rate from a property. */
>   	device_property_read_u32(dev, "clock-frequency", &uartclk);
>   
> -	s->polling = !!irq;
> +	s->polling = (irq <= 0);
>   	if (s->polling)
>   		dev_dbg(dev,
>   			"No interrupt pin definition, falling back to polling mode\n");


-- 
js
suse labs