linux-kernel - Re: [PATCH] USB: Add LPM quirk for sony xperia xz1 compact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025011608-shady-recite-62f6@gregkh>
Date: Thu, 16 Jan 2025 11:10:50 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Forest <forestix@....one>
Cc: linux-kernel@...r.kernel.org,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	linux-usb@...r.kernel.org, regressions@...ts.linux.dev
Subject: Re: [PATCH] USB: Add LPM quirk for sony xperia xz1 compact

On Wed, Jan 15, 2025 at 04:18:22PM -0800, Forest wrote:
> Since USB 2 LPM was enabled for this device by 63a1f8454962
> ("xhci: stored cached port capability values in one place"),
> the fastboot tool for communicating with Android bootloaders no longer
> works reliably. Various fastboot commands are affected, including the
> following, which usually reproduces the problem within two tries:
> 
>   fastboot getvar kernel
> 
> A typical error message when that command fails:
> 
>   getvar:kernel  FAILED (remote: 'GetVar Variable Not found')
> 
> Adding the quirk resolves the regression. No drawbacks are expected,
> since the device uses different USB product IDs outside of fastboot
> mode, and since fastboot commands worked until LPM was enabled by the
> aforementioned commit.
> 
> Cc: stable@...r.kernel.org
> Link: https://lore.kernel.org/hk8umj9lv4l4qguftdq1luqtdrpa1gks5l@sonic.net
> Signed-off-by: Forest <forestix@....one>
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)

Always use scripts/get_maintainer.pl to get the correct people to cc:

Also, we need a "real" name here, sorry.

thanks,

greg k-h