linux-kernel - Re: [PATCH v1 0/6] Mypy and pylint build support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64a3dadc-7c37-4e05-8d42-445142691777@linaro.org>
Date: Thu, 16 Jan 2025 10:58:09 +0000
From: James Clark <james.clark@...aro.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 Kan Liang <kan.liang@...ux.intel.com>, John Garry <john.g.garry@...cle.com>,
 Athira Jajeev <atrajeev@...ux.vnet.ibm.com>,
 Veronika Molnarova <vmolnaro@...hat.com>, Ze Gao <zegao2021@...il.com>,
 linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v1 0/6] Mypy and pylint build support



On 16/01/2025 10:56 am, James Clark wrote:
> 
> 
> On 25/10/2024 6:22 pm, Ian Rogers wrote:
>> Support building perf checking the python code with mypy and/or
>> pylint. Currently there are too many errors to make this a default.
>>
>> Shellcheck generates no output on success, so linking shellcheck files
>> doesn't cause `ld` to fail. Mypy and pylint generate output that will
>> break `ld` so change the Makefile.build to ignore test log files.
>>
>> Address some initial mypy errors.
>>
>> Ian Rogers (6):
>>    tools/build: Don't pass test log files to linker
>>    perf build: Rename TEST_LOGS to SHELL_TEST_LOGS
>>    perf build: Add mypy build tests
>>    perf build: Add pylint build tests
>>    perf test: Address attr.py mypy error
>>    perf python: Fix setup.py mypy errors
>>
>>   tools/build/Makefile.build         |  6 +++++-
>>   tools/perf/Build                   | 32 +++++++++++++++++++++++++++---
>>   tools/perf/Makefile.perf           | 14 +++++++++++--
>>   tools/perf/arch/x86/Build          |  6 +++---
>>   tools/perf/arch/x86/tests/Build    |  6 +++---
>>   tools/perf/pmu-events/Build        | 25 ++++++++++++++++++++++-
>>   tools/perf/scripts/Build           | 26 ++++++++++++++++++++++++
>>   tools/perf/tests/Build             | 32 +++++++++++++++++++++++++++---
>>   tools/perf/tests/shell/lib/attr.py |  8 +-------
>>   tools/perf/trace/beauty/Build      |  6 +++---
>>   tools/perf/util/Build              | 31 ++++++++++++++++++++++++++---
>>   tools/perf/util/setup.py           | 10 ++++++++--
>>   12 files changed, 171 insertions(+), 31 deletions(-)
>>
> 
> Reviewed-by: James Clark <james.clark@...aro.org>
> 
>    $ make PYLINT=1 MYPY=1
> 
>    TEST    python/twatch.py.pylint_log
>    ...
>    Your code has been rated at -5.00/10
>    ...

I forgot to add this:

  :(

I didn't know it could go negative.