linux-kernel - Re: [PATCH v5 2/3] firmware: add Exynos ACPM protocol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77eeed18-4a48-4407-ae83-7a922045b29a@linaro.org>
Date: Thu, 16 Jan 2025 11:41:42 +0000
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Jassi Brar <jassisinghbrar@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 andre.draszik@...aro.org, kernel-team@...roid.com, willmcvicker@...gle.com,
 peter.griffin@...aro.org, daniel.lezcano@...aro.org,
 vincent.guittot@...aro.org, ulf.hansson@...aro.org, arnd@...db.de
Subject: Re: [PATCH v5 2/3] firmware: add Exynos ACPM protocol driver

On 12/31/24 2:32 PM, Tudor Ambarus wrote:
>>> +config EXYNOS_ACPM_PROTOCOL
>>> +	tristate "Exynos Alive Clock and Power Manager (ACPM) Message Protocol"
>>> +	depends on ARCH_EXYNOS || COMPILE_TEST
>>> +	depends on EXYNOS_MBOX
>> Is it build time dependency? No || COMPILE_TEST?
> There's no build time dependency, I'll drop this line.

There's no build time dependency on EXYNOS_MBOX, but there is on MAILBOX:

ERROR: modpost: "mbox_request_channel"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
ERROR: modpost: "mbox_free_channel"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
ERROR: modpost: "mbox_send_message"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
ERROR: modpost: "mbox_client_txdone"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!

Will replace the line with "depends on MAILBOX".

Thanks!
ta