linux-kernel - Re: [PATCH v2] irqchip/irq-brcmstb-l2: Replace brcmstb_l2_mask_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4jyq3xwlkPVrtts@gallifrey>
Date: Thu, 16 Jan 2025 11:51:07 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	x86@...nel.org, oe-kbuild-all@...ts.linux.dev,
	linux-mips@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] irqchip/irq-brcmstb-l2: Replace
 brcmstb_l2_mask_and_ack() by generic function

* Thomas Gleixner (tglx@...utronix.de) wrote:
> David!
> 
> On Thu, Jan 16 2025 at 00:59, linux@...blig.org wrote:
> > Replace brcmstb_l2_mask_and_ack() by the generic
> > irq_gc_mask_disable_and_ack_set().
> >
> > brcmstb_l2_mask_and_ack() was added in commit 49aa6ef0b439
> > ("irqchip/brcmstb-l2: Remove some processing from the handler") in
> > September 2017 with a comment saying it was actually generic and someone
> > should add it to the generic code.
> >
> > commit 20608924cc2e ("genirq: generic chip: Add
> > irq_gc_mask_disable_and_ack_set()") did that a few weeks later, however no
> > one went back and took the brcmstb variant out.
> 
> That's too late. The original patch is already applied and I'm not going
> to redo the whole branch for this minor hickup. I've converted it to a
> delta fix.

Thanks.

> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> 
> You cannot add my Signed-off-by to a new submission.

Apologies.

Dave

> Thanks,
> 
>         tglx
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/