linux-kernel - Re: [PATCH v1] sched: Mention autogroup disabled behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fzshiseda5ispy7utboswemxr54d7646rz5v2ilgatlih3vqwk@r3775k54ixeh>
Date: Thu, 16 Jan 2025 14:06:26 +0100
From: Alejandro Colomar <alx@...nel.org>
To: Phil Auld <pauld@...hat.com>
Cc: linux-man@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] sched: Mention autogroup disabled behavior

Hi Phil,

> Subject: sched: Mention autogroup disabled behavior

Please use the pathname of the modified file as a prefix:

	man/man7/sched.7: Mention autogroup disabled behavior

On Thu, Jan 16, 2025 at 12:46:54PM +0000, Phil Auld wrote:
> The autogroup feature can be contolled at runtime when
> built into the kernel. Disabling it in this case still
> creates autogroups and still shows the autogroup membership
> for the task in /proc.  The scheduler code will just not
> use the the autogroup task group.

Would you mind showing (in the commit message) a shell session that
demonstrates this?

>  This can be confusing
> to users. Add a sentence to this effect to sched.7 to
> point this out.
> 
> Signed-off-by: Phil Auld <pauld@...hat.com>
> To: Alejandro Colomar <alx@...nel.org>
> Cc: <linux-man@...r.kernel.org>
> Cc: LKML <linux-kernel@...r.kernel.org>

Thanks!

> 
> ---
>  man/man7/sched.7 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/man/man7/sched.7 b/man/man7/sched.7
> index 71f098e48..f0a708cd7 100644
> --- a/man/man7/sched.7
> +++ b/man/man7/sched.7
> @@ -724,6 +724,8 @@ in the group terminates.
>  .P
>  When autogrouping is enabled, all of the members of an autogroup
>  are placed in the same kernel scheduler "task group".
> +When disabled the group creation happens as above, and autogroup membership

s/disabled/&,/

Also, please use semantic newlines.  See man-pages(7):

$ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p'
   Use semantic newlines
     In the source of a manual page, new sentences should be started on
     new lines, long sentences should be split  into  lines  at  clause
     breaks  (commas,  semicolons, colons, and so on), and long clauses
     should be split at phrase boundaries.  This convention,  sometimes
     known as "semantic newlines", makes it easier to see the effect of
     patches, which often operate at the level of individual sentences,
     clauses, or phrases.


Have a lovely day!
Alex

> +is still visible in /proc, but the autogroups are not used.
>  The CFS scheduler employs an algorithm that equalizes the
>  distribution of CPU cycles across task groups.
>  The benefits of this for interactive desktop performance
> -- 
> 2.47.0
> 

-- 
<https://www.alejandro-colomar.es/>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)