linux-kernel - Re: [PATCH] cgroup/cpuset: Move procfs cpuset attribute under cgroup-v1.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b90d0be9-b970-442d-874d-1031a63d1058@redhat.com>
Date: Thu, 16 Jan 2025 08:40:56 -0500
From: Waiman Long <llong@...hat.com>
To: Michal Koutný <mkoutny@...e.com>,
 linux-kernel@...r.kernel.org, cgroups@...r.kernel.org
Cc: Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>,
 Chen Ridong <chenridong@...wei.com>
Subject: Re: [PATCH] cgroup/cpuset: Move procfs cpuset attribute under
 cgroup-v1.c

On 1/16/25 4:56 AM, Michal Koutný wrote:
> The cpuset file is a legacy attribute that is bound primarily to cpuset
> v1 (and it'd be equal to effective /proc/$pid/cgroup path on the unified
> hierarchy).
>
> Followup to commit b0ced9d378d49 ("cgroup/cpuset: move v1 interfaces to
> cpuset-v1.c") and hide CONFIG_PROC_PID_CPUSET under CONFIG_CPUSETS_V1.
> Drop an obsolete comment too.
>
> Signed-off-by: Michal Koutný <mkoutny@...e.com>

I do have some reservation in taking out /proc/<pid>/cpuset by default 
as CPUSETS_V1 is off by default. This may break some existing user scripts.

Also the statement that the cpuset file is the same as the path in 
cgroup file in unified hierarchy is not true if that cgroup doesn't have 
cpuset enabled.

Cheers,
Longman