linux-kernel - Re: [PATCH] net: mii: Fix the Speed display when the network cable is not connected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11039148-82ea-4dea-8734-47eabdb268ef@linux.dev>
Date: Thu, 16 Jan 2025 09:42:16 +0800
From: Yanteng Si <si.yanteng@...ux.dev>
To: Xiangqian Zhang <zhangxiangqian@...inos.cn>, andrew+netdev@...n.ch
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mii: Fix the Speed display when the network cable is
 not connected

在 2025/1/15 19:18, Xiangqian Zhang 写道:
> Two different models of usb card, the drivers are r8152 and asix. If no
> network cable is connected, Speed = 10Mb/s. This problem is repeated in
> linux 3.10, 4.19, and 5.4. Both drivers call
> mii_ethtool_get_link_ksettings, but the value of cmd->base.speed in this
> function can only be SPEED_1000 or SPEED_100 or SPEED_10.
> When the network cable is not connected, set cmd->base.speed
> =SPEED_UNKNOWN.
> 
> v2:
> https://lore.kernel.org/20250111132242.3327654-1-zhangxiangqian@kylinos.cn
So, you've already sent a v2. This patch should be sent as v3.

Also, the link to v2 should not be included in the commit message. 
Instead, it should be placed here:

---
v2: 
https://lore.kernel.org/20250111132242.3327654-1-zhangxiangqian@kylinos.cn

  drivers/net/mii.c | 3 +++
  1 file changed, 3 insertions(+)

Thanks,
Yanteng