[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABymUCPn=u8jr_OTFwB-WBjj2nNgBeTyH5b=PvF5vLrDhCxr3Q@mail.gmail.com>
Date: Thu, 16 Jan 2025 22:22:07 +0800
From: Jun Nie <jun.nie@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Rob Clark <robdclark@...il.com>, Abhinav Kumar <quic_abhinavk@...cinc.com>,
Sean Paul <sean@...rly.run>, Marijn Suijten <marijn.suijten@...ainline.org>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, linux-arm-msm@...r.kernel.org,
dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 14/16] drm/msm/dpu: support SSPP assignment for
quad-pipe case
Dmitry Baryshkov <dmitry.baryshkov@...aro.org> 于2025年1月16日周四 16:18写道:
>
> On Thu, Jan 16, 2025 at 03:26:03PM +0800, Jun Nie wrote:
> > Support SSPP assignment for quad-pipe case with unified method.
> > The first 2 pipes can share a set of mixer config and enable
> > multi-rect mode if condition is met. It is also the case for
> > the later 2 pipes.
>
> Missing problem description.
Is this OK?
SSPP are assigned for 2 pipes at most with current implementation,
while 4 pipes are required in quad-pipe usage case with involving
configuration of 2 stages. Assign SSPPs for pipes of a stage in a
loop with unified method. The first 2 pipes can shar a set of mixer
config and enable multi-rect mode if condition is met. It is also the
case for the later 2 pipes.
>
> Also, shouldn't this patch come before the previous one?
>
Yeah, it is reasonable to prepare the assignment capability, then
enable the plane splitting into 4 pipes. It does not hurt actually
because quad-pipe is not enabled in data structure side.
Will reverse the sequence in next version anyway.
Jun
Powered by blists - more mailing lists