linux-kernel - Re: [PATCH v3] arm64: dts: qcom: qcs8300: add QCrypto nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqL0HzzGXnCD+z4GASeXNsBxrdw8-qyfHj8S+C2ucK6EPQ@mail.gmail.com>
Date: Thu, 16 Jan 2025 08:34:18 -0600
From: Rob Herring <robh@...nel.org>
To: Yuvaraj Ranganathan <quic_yrangana@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] arm64: dts: qcom: qcs8300: add QCrypto nodes

On Mon, Dec 23, 2024 at 5:09 AM Yuvaraj Ranganathan
<quic_yrangana@...cinc.com> wrote:
>
> Add the QCE and Crypto BAM DMA nodes.
>
> Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@...cinc.com>
> ---
> Changes in v3:
>  - Wrap the lengthy lines
>  - Reduced the patch series as other patch is merged.
>  - Link to v2: https://lore.kernel.org/all/20241125111923.2218374-3-quic_yrangana@quicinc.com/
>
> Changes in v2:
>  - Set the interconnect tag to QCOM_ICC_TAG_ALWAYS instead of passing 0(no TAG).
>  - Link to v1:  https://lore.kernel.org/all/20241113055830.2918347-1-quic_yrangana@quicinc.com/
>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300.dtsi | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> index 73abf2ef9c9f..30c1de1c4ad2 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> @@ -736,6 +736,31 @@ ufs_mem_phy: phy@...7000 {
>                         status = "disabled";
>                 };
>
> +               cryptobam: dma-controller@...4000 {
> +                       compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> +                       reg = <0x0 0x01dc4000 0x0 0x28000>;
> +                       interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
> +                       #dma-cells = <1>;
> +                       qcom,ee = <0>;
> +                       qcom,controlled-remotely;
> +                       num-channels = <20>;
> +                       qcom,num-ees = <4>;
> +                       iommus = <&apps_smmu 0x480 0x00>,
> +                                <&apps_smmu 0x481 0x00>;
> +               };
> +
> +               crypto: crypto@...a000 {
> +                       compatible = "qcom,qcs8300-qce", "qcom,qce";

This doesn't match what the schema says.

You didn't test your schema change with this. That's the *whole* point
of the schemas...

Rob