linux-kernel - Re: [PATCH net-next] mptcp: fix for setting remote ipv4mapped address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <99b3e4bc-5696-4731-b26c-17fd21087716@kernel.org>
Date: Thu, 16 Jan 2025 16:06:51 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: mptcp@...ts.linux.dev, Mat Martineau <martineau@...nel.org>,
 Geliang Tang <geliang@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] mptcp: fix for setting remote ipv4mapped address

Hi Jakub,

On 15/01/2025 22:21, Jakub Kicinski wrote:
> On Tue, 14 Jan 2025 19:06:22 +0100 Matthieu Baerts (NGI0) wrote:
>> From: Geliang Tang <tanggeliang@...inos.cn>
>>
>> Commit 1c670b39cec7 ("mptcp: change local addr type of subflow_destroy")
>> introduced a bug in mptcp_pm_nl_subflow_destroy_doit().
>>
>> ipv6_addr_set_v4mapped() should be called to set the remote ipv4 address
>> 'addr_r.addr.s_addr' to the remote ipv6 address 'addr_r.addr6', not
>> 'addr_l.addr.addr6', which is the local ipv6 address.
> 
> Wasn't there a syzbot report for this? Just curious.

Apparently no :)

>From what I understood, Geliang spotted that while looking at the code
around.

Thank you for having applied the patches!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.