linux-kernel - Re: [PATCH 0/5] spi: zynqmp-gqspi: Improve error recovery by resetting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h65xi977.fsf@bootlin.com>
Date: Fri, 17 Jan 2025 19:31:08 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Mark Brown <broonie@...nel.org>
Cc: Sean Anderson <sean.anderson@...ux.dev>,  Michal Simek
 <michal.simek@....com>,  linux-spi@...r.kernel.org,
  linux-kernel@...r.kernel.org,  Jinjie Ruan <ruanjinjie@...wei.com>,
  linux-arm-kernel@...ts.infradead.org,  Amit Kumar Mahapatra
 <amit.kumar-mahapatra@....com>,  Conor Dooley <conor+dt@...nel.org>,
  Krzysztof Kozlowski <krzk+dt@...nel.org>,  Rob Herring <robh@...nel.org>,
  devicetree@...r.kernel.org
Subject: Re: [PATCH 0/5] spi: zynqmp-gqspi: Improve error recovery by resetting

On 17/01/2025 at 13:21:58 GMT, Mark Brown <broonie@...nel.org> wrote:

> On Thu, Jan 16, 2025 at 05:55:16PM -0500, Sean Anderson wrote:
>> This series adds support for resetting the QSPI controller if we have a
>> timeout. I find this greatly improves the stability of the device, which
>> would tend to break after any timeout.
>
> If you're hitting a timeout that tends to indicate there's already a
> serious stability problem...

Yes, unless the timeout is reached for "good reasons", ie. you request
substantial amounts of data (typically from a memory device) and the
timeout is too short compared to the theoretical time spent in the
transfer. A loaded machine can also increase the number of false
positives I guess.

Cheers,
Miquèl