linux-kernel - RE: [PATCH v5 03/12] x86/mm: consolidate full flush threshold decision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SN6PR02MB41574BB1004E584168B8D30BD41B2@SN6PR02MB4157.namprd02.prod.outlook.com>
Date: Fri, 17 Jan 2025 19:23:03 +0000
From: Michael Kelley <mhklinux@...look.com>
To: "riel@...riel.com" <riel@...riel.com>, "x86@...nel.org" <x86@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"bp@...en8.de" <bp@...en8.de>, "peterz@...radead.org" <peterz@...radead.org>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"zhengqi.arch@...edance.com" <zhengqi.arch@...edance.com>,
	"nadav.amit@...il.com" <nadav.amit@...il.com>, "thomas.lendacky@....com"
	<thomas.lendacky@....com>, "kernel-team@...a.com" <kernel-team@...a.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "jannh@...gle.com" <jannh@...gle.com>,
	"andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>, Dave Hansen
	<dave.hansen@...el.com>
Subject: RE: [PATCH v5 03/12] x86/mm: consolidate full flush threshold
 decision

From: riel@...riel.com <riel@...riel.com> Sent: Wednesday, January 15, 2025 6:30 PM
> 
> Reduce code duplication by consolidating the decision point
> for whether to do individual invalidations or a full flush
> inside get_flush_tlb_info.
> 
> Signed-off-by: Rik van Riel <riel@...riel.com>
> Suggested-by: Dave Hansen <dave.hansen@...el.com>
> ---
>  arch/x86/mm/tlb.c | 43 ++++++++++++++++++++-----------------------
>  1 file changed, 20 insertions(+), 23 deletions(-)
> 
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 6cf881a942bb..2f38cf95dee3 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c

[snip]

> @@ -1089,22 +1089,19 @@ static void do_kernel_range_flush(void *info)
> 
>  void flush_tlb_kernel_range(unsigned long start, unsigned long end)
>  {
> -	/* Balance as user space task's flush, a bit conservative */
> -	if (end == TLB_FLUSH_ALL ||
> -	    (end - start) > tlb_single_page_flush_ceiling << PAGE_SHIFT) {
> -		on_each_cpu(do_flush_tlb_all, NULL, 1);
> -	} else {
> -		struct flush_tlb_info *info;
> +	struct flush_tlb_info *info;
> 
> -		preempt_disable();
> -		info = get_flush_tlb_info(NULL, start, end, 0, false,
> -					  TLB_GENERATION_INVALID);
> +	guard(preempt)();
> +
> +	info = get_flush_tlb_info(NULL, start, end, PAGE_SHIFT, false,
> +				  TLB_GENERATION_INVALID);
> 
> +	if (end == TLB_FLUSH_ALL)

This needs to test "info->end", not "end".

In my VM on Hyper-V *without* INVLPGB support, the bug causes
boot to hang as it tries to individually flush each page in the
[0, TLB_FLUSH_ALL] range. :-)

Michael

> +		on_each_cpu(do_flush_tlb_all, NULL, 1);
> +	else
>  		on_each_cpu(do_kernel_range_flush, info, 1);
> 
> -		put_flush_tlb_info();
> -		preempt_enable();
> -	}
> +	put_flush_tlb_info();
>  }
> 
>  /*