| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <f4e08213-0f42-4f35-a150-a75bf91537bf@app.fastmail.com>
Date: Fri, 17 Jan 2025 15:45:34 -0500
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
"Kurt Borja" <kuurtb@...il.com>
Cc:
"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>, "Len Brown" <lenb@...nel.org>,
"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
"Limonciello, Mario" <mario.limonciello@....com>,
"Armin Wolf" <W_Armin@....de>, "Joshua Grisham" <josh@...huagrisham.com>,
"Derek J . Clark" <derekjohn.clark@...il.com>,
"Hans de Goede" <hdegoede@...hat.com>,
"Maximilian Luz" <luzmaximilian@...il.com>, "Lee Chun-Yi" <jlee@...e.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@....com>,
"Corentin Chary" <corentin.chary@...il.com>,
"Luke D . Jones" <luke@...nes.dev>, "Lyndon Sanche" <lsanche@...deno.ca>,
"Ike Panhc" <ike.pan@...onical.com>,
"Henrique de Moraes Holschuh" <hmh@....eng.br>,
"Alexis Belmonte" <alexbelm48@...il.com>, "Ai Chao" <aichao@...inos.cn>,
"Gergo Koteles" <soyer@....hu>, Dell.Client.Kernel@...l.com,
ibm-acpi-devel@...ts.sourceforge.net
Subject: Re: [PATCH v4 00/19] Hide platform_profile_handler from consumers
Hi,
On Fri, Jan 17, 2025, at 12:19 PM, Ilpo Järvinen wrote:
> On Fri, 17 Jan 2025, Kurt Borja wrote:
>
>> On Fri Jan 17, 2025 at 11:42 AM -05, Ilpo Järvinen wrote:
>> > On Thu, 16 Jan 2025, Mark Pearson wrote:
>> >
>> > > Hi
>> > >
>> > > On Wed, Jan 15, 2025, at 7:27 PM, Kurt Borja wrote:
>> > > > Hi :)
>> > > >
>> > > > The merge window is about to open, so I rebased this patchset on top of
>> > > > pdx86/review-ilpo-next to pick up acer-wmi latest commits, in case we
>> > > > manage to squeeze this into v6.14.
>> > > >
>> > > > ~ Kurt
>> > > > ---
>> > > > v3 -> v4:
>> > > >
>> > > > [09/19]
>> > > > - Replace error message with a user-friendly one
>> > > >
>> > > > v3:
>> > > > https://lore.kernel.org/platform-driver-x86/20250115071022.4815-1-kuurtb@gmail.com/
>> > > >
>> > > > Kurt Borja (19):
>> > > > ACPI: platform_profile: Replace *class_dev member with class_dev
>> > > > ACPI: platform_profile: Let drivers set drvdata to the class device
>> > > > ACPI: platform_profile: Remove platform_profile_handler from callbacks
>> > > > ACPI: platform_profile: Add `ops` member to handlers
>> > > > ACPI: platform_profile: Add `probe` to platform_profile_ops
>> > > > platform/surface: surface_platform_profile: Use
>> > > > devm_platform_profile_register()
>> > > > platform/x86: acer-wmi: Use devm_platform_profile_register()
>> > > > platform/x86: amd: pmf: sps: Use devm_platform_profile_register()
>> > > > platform/x86: asus-wmi: Use devm_platform_profile_register()
>> > > > platform/x86: dell-pc: Use devm_platform_profile_register()
>> > > > platform/x86: ideapad-laptop: Use devm_platform_profile_register()
>> > > > platform/x86: hp-wmi: Use devm_platform_profile_register()
>> > > > platform/x86: inspur_platform_profile: Use
>> > > > devm_platform_profile_register()
>> > > > platform/x86: thinkpad_acpi: Use devm_platform_profile_register()
>> > > > ACPI: platform_profile: Remove platform_profile_handler from exported
>> > > > symbols
>> > > > ACPI: platform_profile: Move platform_profile_handler
>> > > > ACPI: platform_profile: Clean platform_profile_handler
>> > > > ACPI: platform_profile: Add documentation
>> > > > ACPI: platform_profile: Add a prefix to log messages
>> > > >
>> > > > .../ABI/testing/sysfs-class-platform-profile | 44 +++++
>> > > > drivers/acpi/platform_profile.c | 172 +++++++++++++-----
>> > > > .../surface/surface_platform_profile.c | 48 ++---
>> > > > drivers/platform/x86/acer-wmi.c | 114 ++++++------
>> > > > drivers/platform/x86/amd/pmf/core.c | 1 -
>> > > > drivers/platform/x86/amd/pmf/pmf.h | 3 +-
>> > > > drivers/platform/x86/amd/pmf/sps.c | 51 +++---
>> > > > drivers/platform/x86/asus-wmi.c | 55 +++---
>> > > > drivers/platform/x86/dell/alienware-wmi.c | 34 ++--
>> > > > drivers/platform/x86/dell/dell-pc.c | 60 +++---
>> > > > drivers/platform/x86/hp/hp-wmi.c | 83 +++++----
>> > > > drivers/platform/x86/ideapad-laptop.c | 45 +++--
>> > > > .../platform/x86/inspur_platform_profile.c | 48 +++--
>> > > > drivers/platform/x86/thinkpad_acpi.c | 37 ++--
>> > > > include/linux/platform_profile.h | 37 ++--
>> > > > 15 files changed, 495 insertions(+), 337 deletions(-)
>> > > > create mode 100644 Documentation/ABI/testing/sysfs-class-platform-profile
>> > > >
>> > > >
>> > > > base-commit: d98bf6a6ed61a8047e199495b0887cce392f8e5b
>> > > > --
>> > > > 2.48.1
>> > >
>> > > For the series up to v4 commit 15/19:
>> > > Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
>> > >
>> > > I need to go over the last few commits just once more, as there a few
>> > > pieces I need to get my head around - and I'm not going to get it done
>> > > this evening. Hope it's OK to add review for the bits that I have done.
>> >
>> > I, for the first time ever, tested filter-branch and after some initial
>> > hickups on how to specify the commit range, got your Reviewed-bys added
>> > with single command :-).
>>
>> Awesome! I believe commit 15/19
>>
>> a213108c01e0 ("ACPI: platform_profile: Remove platform_profile_handler from exported symbols")
>>
>> is still missing a rev-by by Mark, if there is still time.
>
> Thanks for noticing this. I just recalled the patch numbering wrong.
>
> It should be fixed now.
>
> --
> i.
I finished my review, and no concerns. For the series:
Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
Note - I'm building and will give it a sniff test too, but that will take a bit longer.
Thanks for your work on this Kurt
Mark
Powered by blists - more mailing lists