linux-kernel - Re: [PATCH] net/ncsi: Fix NULL pointer derefence if CIS arrives before SP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250117144332.7ea38896@kernel.org>
Date: Fri, 17 Jan 2025 14:43:32 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Eddie James <eajames@...ux.ibm.com>
Cc: Paul Fertser <fercerpav@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, horms@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, davem@...emloft.net, sam@...dozajonas.com, Ivan
 Mikhaylov <fr0st61te@...il.com>
Subject: Re: [PATCH] net/ncsi: Fix NULL pointer derefence if CIS arrives
 before SP

On Fri, 17 Jan 2025 15:05:24 -0600 Eddie James wrote:
> I am able to reproduce the panic at will, and unfortunately your patch 
> does not prevent the issue.
> 
> However I suspect this issue may be unique to my set up, so my patch may 
> not be necessary. I found that I had some user space issues. Fixing 
> userspace prevented this issue.

The kernel shouldn't crash even if user space is buggy..
Maybe we can apply a simplified patch to return an error if !np?