linux-kernel - Re: [PATCH v4 14/16] drm/msm/dpu: support SSPP assignment for quad-pipe case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tae55nwbytxtmskvlelwkldy6tkgurr3mxocpfdhvniuiduxb4@qosnxo2dseu2>
Date: Fri, 17 Jan 2025 05:39:49 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jun Nie <jun.nie@...aro.org>
Cc: Rob Clark <robdclark@...il.com>, 
	Abhinav Kumar <quic_abhinavk@...cinc.com>, Sean Paul <sean@...rly.run>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 14/16] drm/msm/dpu: support SSPP assignment for
 quad-pipe case

On Thu, Jan 16, 2025 at 10:22:07PM +0800, Jun Nie wrote:
> Dmitry Baryshkov <dmitry.baryshkov@...aro.org> 于2025年1月16日周四 16:18写道：
> >
> > On Thu, Jan 16, 2025 at 03:26:03PM +0800, Jun Nie wrote:
> > > Support SSPP assignment for quad-pipe case with unified method.
> > > The first 2 pipes can share a set of mixer config and enable
> > > multi-rect mode if condition is met. It is also the case for
> > > the later 2 pipes.
> >
> > Missing problem description.
> 
> Is this OK?
>     SSPP are assigned for 2 pipes at most with current implementation,
>     while 4 pipes are required in quad-pipe usage case with involving
>     configuration of 2 stages. Assign SSPPs for pipes of a stage in a
>     loop with unified method. The first 2 pipes can shar a set of mixer
>     config and enable multi-rect mode if condition is met. It is also the
>     case for the later 2 pipes.

No. It should be problem / analysys/ solution. So, 'Assign foo' should
become a last phrase.  Also please please perform a grammar / typos check.

> 
> >
> > Also, shouldn't this patch come before the previous one?
> >
> Yeah, it is reasonable to prepare the assignment capability, then
> enable the plane splitting into 4 pipes. It does not hurt actually
> because quad-pipe is not enabled in data structure side.
> Will reverse the sequence in next version anyway.

Thanks!

-- 
With best wishes
Dmitry