| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202501171437.tCtg3x1c-lkp@intel.com>
Date: Fri, 17 Jan 2025 14:14:59 +0800
From: kernel test robot <lkp@...el.com>
To: Ruidong Tian <tianruidong@...ux.alibaba.com>, catalin.marinas@....com,
will@...nel.org, lpieralisi@...nel.org, guohanjun@...wei.com,
sudeep.holla@....com, xueshuai@...ux.alibaba.com,
baolin.wang@...ux.alibaba.com, linux-kernel@...r.kernel.org,
linux-acpi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
rafael@...nel.org, lenb@...nel.org, tony.luck@...el.com,
bp@...en8.de, yazen.ghannam@....com
Cc: oe-kbuild-all@...ts.linux.dev, tianruidong@...ux.alibaba.com
Subject: Re: [PATCH v3 4/5] RAS/ATL: Unified ATL interface for ARM64 and AMD
Hi Ruidong,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge arm64/for-next/core ras/edac-for-next linus/master tip/smp/core v6.13-rc7 next-20250116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ruidong-Tian/ACPI-RAS-AEST-Initial-AEST-driver/20250115-164601
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20250115084228.107573-5-tianruidong%40linux.alibaba.com
patch subject: [PATCH v3 4/5] RAS/ATL: Unified ATL interface for ARM64 and AMD
config: x86_64-randconfig-074-20250117 (https://download.01.org/0day-ci/archive/20250117/202501171437.tCtg3x1c-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250117/202501171437.tCtg3x1c-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501171437.tCtg3x1c-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/ras/amd/fmpm.c: In function 'save_spa':
>> drivers/ras/amd/fmpm.c:329:15: error: implicit declaration of function 'amd_convert_umc_mca_addr_to_sys_addr'; did you mean 'convert_umc_mca_addr_to_sys_addr'? [-Werror=implicit-function-declaration]
329 | spa = amd_convert_umc_mca_addr_to_sys_addr(&a_err);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| convert_umc_mca_addr_to_sys_addr
cc1: some warnings being treated as errors
--
drivers/ras/amd/atl/umc.c: In function 'retire_row_mi300':
>> drivers/ras/amd/atl/umc.c:333:24: error: implicit declaration of function 'amd_convert_umc_mca_addr_to_sys_addr'; did you mean 'convert_umc_mca_addr_to_sys_addr'? [-Werror=implicit-function-declaration]
333 | addr = amd_convert_umc_mca_addr_to_sys_addr(a_err);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| convert_umc_mca_addr_to_sys_addr
cc1: some warnings being treated as errors
vim +329 drivers/ras/amd/fmpm.c
6f15e617cc9932 Yazen Ghannam 2024-02-13 291
838850c50884cd Yazen Ghannam 2024-03-01 292 static void save_spa(struct fru_rec *rec, unsigned int entry,
838850c50884cd Yazen Ghannam 2024-03-01 293 u64 addr, u64 id, unsigned int cpu)
838850c50884cd Yazen Ghannam 2024-03-01 294 {
838850c50884cd Yazen Ghannam 2024-03-01 295 unsigned int i, fru_idx, spa_entry;
838850c50884cd Yazen Ghannam 2024-03-01 296 struct atl_err a_err;
838850c50884cd Yazen Ghannam 2024-03-01 297 unsigned long spa;
838850c50884cd Yazen Ghannam 2024-03-01 298
838850c50884cd Yazen Ghannam 2024-03-01 299 if (entry >= max_nr_entries) {
838850c50884cd Yazen Ghannam 2024-03-01 300 pr_warn_once("FRU descriptor entry %d out-of-bounds (max: %d)\n",
838850c50884cd Yazen Ghannam 2024-03-01 301 entry, max_nr_entries);
838850c50884cd Yazen Ghannam 2024-03-01 302 return;
838850c50884cd Yazen Ghannam 2024-03-01 303 }
838850c50884cd Yazen Ghannam 2024-03-01 304
838850c50884cd Yazen Ghannam 2024-03-01 305 /* spa_nr_entries is always multiple of max_nr_entries */
838850c50884cd Yazen Ghannam 2024-03-01 306 for (i = 0; i < spa_nr_entries; i += max_nr_entries) {
838850c50884cd Yazen Ghannam 2024-03-01 307 fru_idx = i / max_nr_entries;
838850c50884cd Yazen Ghannam 2024-03-01 308 if (fru_records[fru_idx] == rec)
838850c50884cd Yazen Ghannam 2024-03-01 309 break;
838850c50884cd Yazen Ghannam 2024-03-01 310 }
838850c50884cd Yazen Ghannam 2024-03-01 311
838850c50884cd Yazen Ghannam 2024-03-01 312 if (i >= spa_nr_entries) {
838850c50884cd Yazen Ghannam 2024-03-01 313 pr_warn_once("FRU record %d not found\n", i);
838850c50884cd Yazen Ghannam 2024-03-01 314 return;
838850c50884cd Yazen Ghannam 2024-03-01 315 }
838850c50884cd Yazen Ghannam 2024-03-01 316
838850c50884cd Yazen Ghannam 2024-03-01 317 spa_entry = i + entry;
838850c50884cd Yazen Ghannam 2024-03-01 318 if (spa_entry >= spa_nr_entries) {
838850c50884cd Yazen Ghannam 2024-03-01 319 pr_warn_once("spa_entries[] index out-of-bounds\n");
838850c50884cd Yazen Ghannam 2024-03-01 320 return;
838850c50884cd Yazen Ghannam 2024-03-01 321 }
838850c50884cd Yazen Ghannam 2024-03-01 322
838850c50884cd Yazen Ghannam 2024-03-01 323 memset(&a_err, 0, sizeof(struct atl_err));
838850c50884cd Yazen Ghannam 2024-03-01 324
838850c50884cd Yazen Ghannam 2024-03-01 325 a_err.addr = addr;
838850c50884cd Yazen Ghannam 2024-03-01 326 a_err.ipid = id;
838850c50884cd Yazen Ghannam 2024-03-01 327 a_err.cpu = cpu;
838850c50884cd Yazen Ghannam 2024-03-01 328
838850c50884cd Yazen Ghannam 2024-03-01 @329 spa = amd_convert_umc_mca_addr_to_sys_addr(&a_err);
838850c50884cd Yazen Ghannam 2024-03-01 330 if (IS_ERR_VALUE(spa)) {
838850c50884cd Yazen Ghannam 2024-03-01 331 pr_debug("Failed to get system address\n");
838850c50884cd Yazen Ghannam 2024-03-01 332 return;
838850c50884cd Yazen Ghannam 2024-03-01 333 }
838850c50884cd Yazen Ghannam 2024-03-01 334
838850c50884cd Yazen Ghannam 2024-03-01 335 spa_entries[spa_entry] = spa;
838850c50884cd Yazen Ghannam 2024-03-01 336 pr_debug("fru_idx: %u, entry: %u, spa_entry: %u, spa: 0x%016llx\n",
838850c50884cd Yazen Ghannam 2024-03-01 337 fru_idx, entry, spa_entry, spa_entries[spa_entry]);
838850c50884cd Yazen Ghannam 2024-03-01 338 }
838850c50884cd Yazen Ghannam 2024-03-01 339
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists