[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP4=nvQUugz723Qav2xBD97ud6sM=ajEeNqyAVyqL1Qf09ZX=Q@mail.gmail.com>
Date: Fri, 17 Jan 2025 08:13:26 +0100
From: Tomas Glozar <tglozar@...hat.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org,
John Kacur <jkacur@...hat.com>, Luis Goncalves <lgoncalv@...hat.com>,
Gabriele Monaco <gmonaco@...hat.com>
Subject: Re: [PATCH 3/5] rtla/timerlat_top: Stop timerlat tracer on signal
pá 17. 1. 2025 v 1:56 odesílatel Steven Rostedt <rostedt@...dmis.org> napsal:
>
> On Thu, 16 Jan 2025 15:49:29 +0100
> Tomas Glozar <tglozar@...hat.com> wrote:
>
> > Apply the changes from the previous patch also to timerlat-top.
>
> A change log should never reference another patch. This is meaningless when
> seen in a git log. All change logs must be complete stand alone.
If you look up "previous patch" in the Linux commit log, you will find
a considerable amount of patches which do this:
$ git log master | grep 'previous patch' | wc -l
3006
But you are right, if I apply this patch for example to fix an old
version of rtla that does not have timerlat-hist, the log will make no
sense. I will stop doing it.
>
> I copied the previous patch change log here:
>
Thank you.
Tomas
Powered by blists - more mailing lists