linux-kernel - Re: [PATCH 3/5] rtla/timerlat_top: Stop timerlat tracer on signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250116195600.60625aa1@gandalf.local.home>
Date: Thu, 16 Jan 2025 19:56:00 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Tomas Glozar <tglozar@...hat.com>
Cc: linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org, John
 Kacur <jkacur@...hat.com>, Luis Goncalves <lgoncalv@...hat.com>, Gabriele
 Monaco <gmonaco@...hat.com>
Subject: Re: [PATCH 3/5] rtla/timerlat_top: Stop timerlat tracer on signal

On Thu, 16 Jan 2025 15:49:29 +0100
Tomas Glozar <tglozar@...hat.com> wrote:

> Apply the changes from the previous patch also to timerlat-top.

A change log should never reference another patch. This is meaningless when
seen in a git log. All change logs must be complete stand alone.

I copied the previous patch change log here:

    rtla/timerlat_top: Stop timerlat tracer on signal
    
    Currently, when either SIGINT from the user or SIGALRM from the duration
    timer is caught by rtla-timerlat, stop_tracing is set to break out of
    the main loop. This is not sufficient for cases where the timerlat
    tracer is producing more data than rtla can consume, since in that case,
    rtla is looping indefinitely inside tracefs_iterate_raw_events, never
    reaches the check of stop_tracing and hangs.
    
    In addition to setting stop_tracing, also stop the timerlat tracer on
    received signal (SIGINT or SIGALRM). This will stop new samples so that
    the existing samples may be processed and tracefs_iterate_raw_events
    eventually exits.

-- Steve