linux-kernel - Re: [PATCH v1 1/3] thermal: core: Rename callback functions in two governors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93c705d7-b5c5-4820-b286-f6794e856a3e@arm.com>
Date: Fri, 17 Jan 2025 08:47:04 +0000
From: Lukasz Luba <lukasz.luba@....com>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v1 1/3] thermal: core: Rename callback functions in two
 governors

Hi Rafael,

On 1/16/25 19:30, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The names of :trip_crossed() callback functions in the Bang-bang and
> User-space thermal governors don't match their current purpose any
> more after previous changes, so rename them.
> 
> No functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>   drivers/thermal/gov_bang_bang.c  |   10 +++++-----
>   drivers/thermal/gov_user_space.c |   10 +++++-----
>   2 files changed, 10 insertions(+), 10 deletions(-)
> 
> --- a/drivers/thermal/gov_bang_bang.c
> +++ b/drivers/thermal/gov_bang_bang.c
> @@ -34,7 +34,7 @@
>   }
>   
>   /**
> - * bang_bang_control - controls devices associated with the given zone
> + * bang_bang_trip_crossed - controls devices associated with the given zone
>    * @tz: thermal_zone_device
>    * @trip: the trip point
>    * @crossed_up: whether or not the trip has been crossed on the way up
> @@ -61,9 +61,9 @@
>    *     (trip_temp - hyst) so that the fan gets turned off again.
>    *
>    */
> -static void bang_bang_control(struct thermal_zone_device *tz,
> -			      const struct thermal_trip *trip,
> -			      bool crossed_up)
> +static void bang_bang_trip_crossed(struct thermal_zone_device *tz,
> +				   const struct thermal_trip *trip,
> +				   bool crossed_up)
>   {
>   	const struct thermal_trip_desc *td = trip_to_trip_desc(trip);
>   	struct thermal_instance *instance;
> @@ -123,7 +123,7 @@
>   
>   static struct thermal_governor thermal_gov_bang_bang = {
>   	.name		= "bang_bang",
> -	.trip_crossed	= bang_bang_control,
> +	.trip_crossed	= bang_bang_trip_crossed,
>   	.manage		= bang_bang_manage,
>   	.update_tz	= bang_bang_update_tz,
>   };
> --- a/drivers/thermal/gov_user_space.c
> +++ b/drivers/thermal/gov_user_space.c
> @@ -23,16 +23,16 @@
>   }
>   
>   /**
> - * notify_user_space - Notifies user space about thermal events
> + * user_space_trip_crossed - Notify user space about trip crossing events
>    * @tz: thermal_zone_device
>    * @trip: trip point
>    * @crossed_up: whether or not the trip has been crossed on the way up
>    *
>    * This function notifies the user space through UEvents.
>    */
> -static void notify_user_space(struct thermal_zone_device *tz,
> -			      const struct thermal_trip *trip,
> -			      bool crossed_up)
> +static void user_space_trip_crossed(struct thermal_zone_device *tz,
> +				    const struct thermal_trip *trip,
> +				    bool crossed_up)
>   {
>   	char *thermal_prop[5];
>   	int i;
> @@ -52,7 +52,7 @@
>   
>   static struct thermal_governor thermal_gov_user_space = {
>   	.name		= "user_space",
> -	.trip_crossed	= notify_user_space,
> +	.trip_crossed	= user_space_trip_crossed,
>   	.bind_to_tz	= user_space_bind,
>   };
>   THERMAL_GOVERNOR_DECLARE(thermal_gov_user_space);
> 
> 
> 

Make sense and LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@....com>