linux-kernel - Re: [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250117084918.GA1752843@rocinante>
Date: Fri, 17 Jan 2025 17:49:18 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Niklas Cassel <cassel@...nel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Hans Zhang <18255117159@....com>, kishon@...nel.org, arnd@...db.de,
	gregkh@...uxfoundation.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, rockswang7@...il.com
Subject: Re: [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar_size

Hello,

> > Since you have already applied this series, with my comment fixed up,
> > could your perhaps add the following (or similar) to the commit message
> > in patch 2/2:
> > 
> > 
> > "
> > By changing the type to resource_size_t, which is a typedef to phys_addr_t,
> > which can be 64-bit in certain configurations (e.g. X86_PAE selects
> > PHYS_ADDR_T_64BIT), even when the compiler is 32-bit. Thus, we also need to
> > change the division to do_div(), to properly perform a 64-bit division when
> > the compiler is 32-bit.
> > "
> 
> s/do_div()/div_u64()/

Will do.  Sounds good!

Thank you!

	Krzysztof