linux-kernel - Re: [PATCH net-next v2 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250117-truthful-reindeer-of-perception-496bd4@krzk-bin>
Date: Fri, 17 Jan 2025 09:56:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, johannes@...solutions.net, p.zabel@...gutronix.de, 
	netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-wireless@...r.kernel.org, m.felsch@...gutronix.de, 
	bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: rfkill-gpio: enable
 booting in blocked state

On Thu, Jan 16, 2025 at 09:47:01AM +0100, Catalin Popescu wrote:
> By default, rfkill state is set to unblocked. Sometimes, we want to boot
> in blocked state and let the application unblock the rfkill.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
> ---
> Changes in v2:
>  - change "default-blocked" type from boolean to flag
> ---
>  Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> index 9630c8466fac..4a706a41ab38 100644
> --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> @@ -32,6 +32,10 @@ properties:
>    shutdown-gpios:
>      maxItems: 1
>  
> +  default-blocked:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: configure rfkill state as blocked at boot

I am assuming rfkill does not have third state possible, so it is only
off or on.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof