linux-kernel - Re: [PATCH v1 1/1] gpio: tps65214: Add support for TI TPS65214 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08ecd393-d5c9-4426-a488-d4fea7067358@kernel.org>
Date: Fri, 17 Jan 2025 10:27:45 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shree Ramamoorthy <s-ramamoorthy@...com>, aaro.koskinen@....fi,
 andreas@...nade.info, khilman@...libre.com, rogerq@...nel.org,
 tony@...mide.com, linus.walleij@...aro.org, brgl@...ev.pl,
 linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org
Cc: m-leonard@...com, praneeth@...com, christophe.jaillet@...adoo.fr
Subject: Re: [PATCH v1 1/1] gpio: tps65214: Add support for TI TPS65214 PMIC

On 16/01/2025 23:38, Shree Ramamoorthy wrote:
>  /*
> - * GPIO driver for TI TPS65215/TPS65219 PMICs
> + * TI TPS65214/TPS65215/TPS65219 PMIC GPIO Driver
>   *
>   * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/
>   */
> @@ -156,6 +156,10 @@ static const struct gpio_chip tps65219_template_chip = {
>  };
>  
>  static const struct tps65219_chip_data chip_info_table[] = {
> +	[TPS65214] = {
> +		.ngpio = 2,
> +		.offset = 1,


So that's the same as TPS65215? Why do you keep duplicating entries?

> +	},
>  	[TPS65215] = {
>  		.ngpio = 2,
>  		.offset = 1,

Best regards,
Krzysztof