linux-kernel - Re: [PATCH] sched_ext: Fix potential deadlock in destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4oo9_SXein4BDnD@gpd3>
Date: Fri, 17 Jan 2025 10:55:03 +0100
From: Andrea Righi <arighi@...dia.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Tejun Heo <tj@...nel.org>, David Vernet <void@...ifault.com>,
	Changwoo Min <changwoo@...lia.com>, linux-kernel@...r.kernel.org,
	herbert@...dor.apana.org.au
Subject: Re: [PATCH] sched_ext: Fix potential deadlock in destroy_dsq()

Hi Breno,

On Fri, Jan 17, 2025 at 01:46:12AM -0800, Breno Leitao wrote:
...
> > Hmm... this is probably the same thing that Breno tried to fix with
> > rhashtable update. Breno, what's the current state of that patch? I saw bug
> > reports and fix patch flying by but didn't track them closely.
> 
> Right, that seems exactly the problem I fixed. This is the current state
> of the issue.
> 
> The fix is already in linux-next, but not on linus' tree:
> 
> 	e1d3422c95f00  Breno Leitao        : rhashtable: Fix potential deadlock by moving schedule_work outside lock

Oh I totally missed your fix.

> 
> That fixes caused a regression[1], and Herbert got a patch, which is not
> committed in linux-next AFAIK.
> 
> This is Herbert's fix:
> 
> 	https://lore.kernel.org/all/Z4XWx5X0doetOJni@gondor.apana.org.au/

If there's something in progress already, feel free to ignore my patch.
I'll do a test on my side later with these fixes applied.

Thanks,
-Andrea

> 
> [1] Link: https://lore.kernel.org/all/Z4DoFYQ3ytB-wS3-@gondor.apana.org.au/
> 
> --breno