linux-kernel - Re: [PATCH v1] usb: typec: tcpci: Prevent Sink disconnection before vPpsShutdown in SPR PPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025011702-pronto-sequel-7e87@gregkh>
Date: Fri, 17 Jan 2025 12:22:02 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Kyle Tso <kyletso@...gle.com>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	andre.draszik@...aro.org, rdbabiera@...gle.com,
	m.felsch@...gutronix.de, xu.yang_2@....com,
	u.kleine-koenig@...libre.com, emanuele.ghidoli@...adex.com,
	badhri@...gle.com, amitsd@...gle.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpci: Prevent Sink disconnection before
 vPpsShutdown in SPR PPS

On Thu, Jan 16, 2025 at 07:41:16PM +0800, Kyle Tso wrote:
> On Thu, Jan 16, 2025 at 7:25 PM Heikki Krogerus
> <heikki.krogerus@...ux.intel.com> wrote:
> >
> > On Tue, Jan 14, 2025 at 10:24:35PM +0800, Kyle Tso wrote:
> > > The Source can drop its output voltage to the minimum of the requested
> > > PPS APDO voltage range when it is in Current Limit Mode. If this voltage
> > > falls within the range of vPpsShutdown, the Source initiates a Hard
> > > Reset and discharges Vbus. However, currently the Sink may disconnect
> > > before the voltage reaches vPpsShutdown, leading to unexpected behavior.
> > >
> > > Prevent premature disconnection by setting the Sink's disconnect
> > > threshold to the minimum vPpsShutdown value. Additionally, consider the
> > > voltage drop due to IR drop when calculating the appropriate threshold.
> > > This ensures a robust and reliable interaction between the Source and
> > > Sink during SPR PPS Current Limit Mode operation.
> > >
> > > Fixes: 4288debeaa4e ("usb: typec: tcpci: Fix up sink disconnect thresholds for PD")
> > > Cc: stable@...r.kernel.org
> > > Signed-off-by: Kyle Tso <kyletso@...gle.com>
> >
> > You've resend this, right? So is this v2 (or v1)?
> >
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> >
> 
> Hello Heikki,
> 
> Thank you for the review.
> 
> Apologies for the resend. This is indeed the v1 patch. The previous
> email was accidentally sent with an incomplete recipient list.

Our tools play havoc when we have duplicates like this, always increment
the version number when resending as obviously you did the resend for
some reason.  Also, it let's us know which ones to review, what would
you do if you saw both of these in your inbox?

I'll try to fix this up by hand this time..

thanks,

greg k-h