linux-kernel - Re: [PATCH v2 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4pdsR-Lyk5c-S1W@smile.fi.intel.com>
Date: Fri, 17 Jan 2025 15:40:01 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH v2 1/1] PM: Revert "Add EXPORT macros for exporting PM
 functions"

On Thu, Jan 16, 2025 at 04:55:05PM +0000, Richard Fitzgerald wrote:
> On 16/01/2025 4:09 pm, Rafael J. Wysocki wrote:
> > On Thu, Jan 16, 2025 at 4:44 PM Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:
> > > 
> > > The introduced macros are not doing what they intend for, namely
> > > they won't eliminate the code when CONFIG_PM=n.
> > 
> > I don't think they have ever been expected to eliminate the code then.
> > They just don't export the symbols in that case.
> > 
> > > Also there were no users of them for all this time.
> 
> I had code changes to use them but they got lost at the bottom of a long
> backlog of other commits and have never been upstreamed. Removing these
> macros is fine with me.

I see, thanks for chiming in in both email threads!

> (apologies if you get this msg twice, there was a problem with email)

-- 
With Best Regards,
Andy Shevchenko