linux-kernel - Re: [PATCH v1 25/29] cxl/amd: Enable Zen5 address translation using ACPI PRMT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4pk75hJqqGg21qy@rric.localdomain>
Date: Fri, 17 Jan 2025 15:10:55 +0100
From: Robert Richter <rrichter@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Gregory Price <gourry@...rry.net>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>,
	Terry Bowman <terry.bowman@....com>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>
Subject: Re: [PATCH v1 25/29] cxl/amd: Enable Zen5 address translation using
 ACPI PRMT

On 17.01.25 11:46:42, Jonathan Cameron wrote:
> On Fri, 17 Jan 2025 08:59:00 +0100
> Robert Richter <rrichter@....com> wrote:
> > On 14.01.25 11:13:07, Jonathan Cameron wrote:

> > > > > static void cxl_port_platform_setup(struct cxl_port *port)
> > > > > {
> > > > > 	cxl_port_setup_amd(port);
> > > > > 	cxl_port_setup_intel(port);
> > > > > 	cxl_port_setup_arm(port);
> > > > > 	... etc ...
> > > > > }
> > > > > 
> > > > > I suppose this logic has to exist somewhere in some form, just want to make
> > > > > sure this is what we want.  Either way, this is easily modifiable, so
> > > > > not a blocker as I said.    
> > > > 
> > > > Yes, it is exactly designed like that. I will update the patch
> > > > description.  
> > > 
> > > If we need it on ARM then we might wrap this in an arch_cxl_port_platform_setup()
> > > as never building a kernel that does x86 and arm.  Could rely on stubs but that
> > > tends to get ugly as things grow.  
> > 
> > I could move the function and file to core/x86/amd.c already and add
> > a:
> > 
> >  void __weak arch_cxl_port_platform_setup(struct cxl_port *port) { }
> Something like that probably makes sense. I don't like x86 calls in what
> I'm building for arm, even if they are stubbed out ;)

Sure, will change that.

Thanks for review,

-Robert