linux-kernel - Re: [PATCH v8 5/5] usb: host: enable USB offload during system sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOuDEK1VvETzWeYjZzKLSoqU_BPwrAjRN039YuEFSivPw2X=Mw@mail.gmail.com>
Date: Fri, 17 Jan 2025 22:30:00 +0800
From: Guan-Yu Lin <guanyulin@...gle.com>
To: Alan Stern <stern@...land.harvard.edu>
Cc: gregkh@...uxfoundation.org, Thinh.Nguyen@...opsys.com, 
	mathias.nyman@...el.com, perex@...ex.cz, tiwai@...e.com, 
	sumit.garg@...aro.org, kekrby@...il.com, oneukum@...e.com, 
	ricardo@...liere.net, lijiayi@...inos.cn, quic_jjohnson@...cinc.com, 
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-sound@...r.kernel.org
Subject: Re: [PATCH v8 5/5] usb: host: enable USB offload during system sleep

On Thu, Jan 16, 2025 at 11:06 PM Alan Stern <stern@...land.harvard.edu> wrote:
>
> On Thu, Jan 16, 2025 at 01:50:17PM +0000, Guan-Yu Lin wrote:
>
> > diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
> > index 1bbf9592724f..6441742869ff 100644
> > --- a/drivers/usb/core/driver.c
> > +++ b/drivers/usb/core/driver.c
> > @@ -1413,19 +1413,31 @@ static int usb_resume_interface(struct usb_device *udev,
> >   */
> >  static int usb_suspend_both(struct usb_device *udev, pm_message_t msg)
> >  {
> > -     int                     status = 0;
> > -     int                     i = 0, n = 0;
> > -     struct usb_interface    *intf;
> > +     int                      status = 0;
> > +     int                      i = 0, n = 0;
> > +     bool                     offload = false;
> > +     struct usb_interface     *intf;
>
> Unnecessary whitespace change.  Please remove this from the patch.
>
> Alan Stern

Thanks for catching this, let me fix it in the next patch.

Regards,
Guan-Yu