linux-kernel - Re: [PATCH 12/16] KVM: TDX: Inhibit APICv for TDX guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4pyEis-6gmBrO1k@google.com>
Date: Fri, 17 Jan 2025 07:08:31 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Kai Huang <kai.huang@...el.com>
Cc: Chao Gao <chao.gao@...el.com>, Rick P Edgecombe <rick.p.edgecombe@...el.com>, 
	"binbin.wu@...ux.intel.com" <binbin.wu@...ux.intel.com>, Xiaoyao Li <xiaoyao.li@...el.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
	Reinette Chatre <reinette.chatre@...el.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, 
	Yan Y Zhao <yan.y.zhao@...el.com>, 
	"tony.lindgren@...ux.intel.com" <tony.lindgren@...ux.intel.com>, "pbonzini@...hat.com" <pbonzini@...hat.com>, 
	Isaku Yamahata <isaku.yamahata@...el.com>
Subject: Re: [PATCH 12/16] KVM: TDX: Inhibit APICv for TDX guest

On Fri, Jan 17, 2025, Kai Huang wrote:
> On Fri, 2025-01-17 at 09:53 +0000, Huang, Kai wrote:
> > Btw, IIUC, in case of IRQCHIP split, KVM uses KVM_IRQ_ROUTING_MSI for routes of
> > GSIs.  But it seems KVM only allows level-triggered MSI to be signaled (which is
> > a surprising):
> > 
> > int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e,
> >                 struct kvm *kvm, int irq_source_id, int level, bool line_status)
> > {
> >         struct kvm_lapic_irq irq;
> > 
> >         if (kvm_msi_route_invalid(kvm, e))
> >                 return -EINVAL;
> > 
> >         if (!level)
> >                 return -1;
> > 
> >         kvm_set_msi_irq(kvm, e, &irq);
> > 
> >         return kvm_irq_delivery_to_apic(kvm, NULL, &irq, NULL);
> > }
> 
> Ah sorry this 'level' is not trig_mode.  Please ignore :-)

Yeah :-(  I have misread the use of "level" so, so many times in KVM's IRQ code.