linux-kernel - Re: [PATCH] sparc/irq: Use str_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19acced3-1935-4eb0-9410-e19bd4196f5a@gaisler.com>
Date: Fri, 17 Jan 2025 16:10:50 +0100
From: Andreas Larsson <andreas@...sler.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 "David S. Miller" <davem@...emloft.net>, Bjorn Helgaas
 <bhelgaas@...gle.com>, Dawei Li <dawei.li@...ngroup.cn>,
 Sam Ravnborg <sam@...nborg.org>, Randy Dunlap <rdunlap@...radead.org>
Cc: sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparc/irq: Use str_enabled_disabled() helper function

On 2025-01-15 10:03, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  arch/sparc/kernel/irq_64.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c
> index 01ee800efde3..aff0d24f8c6f 100644
> --- a/arch/sparc/kernel/irq_64.c
> +++ b/arch/sparc/kernel/irq_64.c
> @@ -22,6 +22,7 @@
>  #include <linux/seq_file.h>
>  #include <linux/ftrace.h>
>  #include <linux/irq.h>
> +#include <linux/string_choices.h>
>  
>  #include <asm/ptrace.h>
>  #include <asm/processor.h>
> @@ -170,7 +171,7 @@ static void __init irq_init_hv(void)
>  
>  	pr_info("SUN4V: Using IRQ API major %d, cookie only virqs %s\n",
>  		hv_irq_version,
> -		sun4v_cookie_only_virqs() ? "enabled" : "disabled");
> +		str_enabled_disabled(sun4v_cookie_only_virqs()));
>  }
>  
>  /* This function is for the timer interrupt.*/

Reviewed-by: Andreas Larsson <andreas@...sler.com>

Picking this up to my for-next.

Thanks,
Andreas