Message-ID: <943a7b09-8e77-4813-810a-18fea0e61482@linux.dev>
Date: Fri, 17 Jan 2025 09:55:00 -0600
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>
To: Guan-Yu Lin <guanyulin@...gle.com>, gregkh@...uxfoundation.org,
 Thinh.Nguyen@...opsys.com, mathias.nyman@...el.com,
 stern@...land.harvard.edu, perex@...ex.cz, tiwai@...e.com,
 sumit.garg@...aro.org, kekrby@...il.com, oneukum@...e.com,
 ricardo@...liere.net, lijiayi@...inos.cn, quic_jjohnson@...cinc.com
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-sound@...r.kernel.org
Subject: Re: [PATCH v9 0/5] Support system sleep with offloaded usb transfers

On 1/17/25 8:48 AM, Guan-Yu Lin wrote:
> Wesley Cheng and Mathias Nyman's USB offload design enables a co-processor
> to handle some USB transfers, potentially allowing the main system to
> sleep and save power. However, Linux's power management system halts the
> USB host controller when the main system isn't managing any USB transfers.
> To address this, the proposal modifies the system to recognize offloaded
> USB transfers and manage power accordingly.

You probably want to expand on the problem statement and clarify quite a few ambiguous statements.

a) "allowing the main system to sleep and save power". What is the 'main system' and what sort of sleep are you referring to? 
Traditionally when playing audio the audio devices remain in D0. Support for playback during 'S0 idle' is more complicated, I have yet to see a working solution even without USB offload in the picture.

b) when referring to power management, you have to be specific on whether you mean 'runtime_pm' or regular power management. Not the same thing but there are related issues.

c) for audio offload the transactions that go through the DSP or co-processor are only for audio endpoints. Control transactions rely on endpoint0 and are NOT offloaded to the best of my knowledge. Which means that you would need to track control transactions as well, even if there is no audio streaming. Otherwise you would have a risk of the XHCI controller transitioning in and out of sleep states.
 
> This involves two key steps:
> 1. Transfer Status Tracking: Propose xhci_sideband_get and
> xhci_sideband_put to track USB transfers on the co-processor, ensuring the
> system is aware of any ongoing activity.


> 2. Power Management Adjustment:  Modifications to the USB driver stack
> (dwc3 controller driver, xhci host controller driver, and USB device
> drivers) allow the system to sleep without disrupting co-processor managed
> USB transfers. This involves adding conditional checks to bypass some
> power management operations.

This is even more confusing, initially the point was to prevent the controller from sleeping while there are offloaded transactions, but now the goal would be to allow the system to sleep while there are offloaded transactions. This isn't the same problem, is it?
 
> patches depends on series "Introduce QC USB SND audio offloading support" 
> https://lore.kernel.org/lkml/20241213235403.4109199-1-quic_wcheng@quicinc.com/T/
> 
> changelog
> ----------
> Changes in v9:
> - Remove unnecessary white space change.
> 
> Changes in v8:
> - Change the runtime pm api to correct the error handling flow.
> - Not flushing endpoints of actively offloaded USB devices to avoid
>   possible USB transfer conflicts.
> 
> Changes in v7:
> - Remove counting mechanism in struct usb_hcd. The USB device's offload
>   status will be solely recorded in each related struct usb_device.
> - Utilizes `needs_remote_wakeup` attribute in struct usb_interface to
>   control the suspend flow of USB interfaces and associated USB endpoints.
>   This addresses the need to support interrupt transfers generated by
>   offloaded USB devices while the system is suspended.
> - Block any offload_usage change during USB device suspend period.
> 
> Changes in v6:
> - Fix build errors when CONFIG_USB_XHCI_SIDEBAND is disabled.
> - Explicitly specify the data structure of the drvdata refereced in
>   dwc3_suspend(), dwc3_resume().
> - Move the initialization of counters to the patches introducing them.
> 
> Changes in v5:
> - Walk through the USB children in usb_sideband_check() to determine the
>   sideband activity under the specific USB device. 
> - Replace atomic_t by refcount_t.
> - Reduce logs by using dev_dbg & remove __func__.
> 
> Changes in v4:
> - Isolate the feature into USB driver stack.
> - Integrate with series "Introduce QC USB SND audio offloading support"
> 
> Changes in v3:
> - Integrate the feature with the pm core framework.
> 
> Changes in v2:
> - Cosmetics changes on coding style.
> 
> [v3] PM / core: conditionally skip system pm in device/driver model
> [v2] usb: host: enable suspend-to-RAM control in userspace
> [v1] [RFC] usb: host: Allow userspace to control usb suspend flows
> ---
> 
> Guan-Yu Lin (5):
>   usb: dwc3: separate dev_pm_ops for each pm_event
>   usb: xhci-plat: separate dev_pm_ops for each pm_event
>   usb: add apis for offload usage tracking
>   xhci: sideband: add api to trace sideband usage
>   usb: host: enable USB offload during system sleep
> 
>  drivers/usb/core/driver.c         | 131 +++++++++++++++++++++++++++++-
>  drivers/usb/core/endpoint.c       |   8 --
>  drivers/usb/core/usb.c            |   4 +
>  drivers/usb/dwc3/core.c           | 105 +++++++++++++++++++++++-
>  drivers/usb/dwc3/core.h           |   1 +
>  drivers/usb/host/xhci-plat.c      |  42 +++++++++-
>  drivers/usb/host/xhci-sideband.c  |  82 +++++++++++++++++++
>  include/linux/usb.h               |  27 +++++-
>  include/linux/usb/hcd.h           |   7 ++
>  include/linux/usb/xhci-sideband.h |   6 ++
>  sound/usb/qcom/qc_audio_offload.c |   3 +
>  11 files changed, 398 insertions(+), 18 deletions(-)
> 

Powered by blists - more mailing lists