| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202501181516.o8Ibdo7z-lkp@intel.com>
Date: Sat, 18 Jan 2025 15:28:15 +0800
From: kernel test robot <lkp@...el.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] usb: typec: ucsi: return CCI and message from
sync_control callback
Hi Dmitry,
kernel test robot noticed the following build errors:
[auto build test ERROR on e7bb221a638962d487231ac45a6699fb9bb8f9fa]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/usb-typec-ucsi-return-CCI-and-message-from-sync_control-callback/20250117-185213
base: e7bb221a638962d487231ac45a6699fb9bb8f9fa
patch link: https://lore.kernel.org/r/20250117-ucsi-merge-commands-v1-1-e20c19934d59%40linaro.org
patch subject: [PATCH 1/3] usb: typec: ucsi: return CCI and message from sync_control callback
config: i386-buildonly-randconfig-004-20250118 (https://download.01.org/0day-ci/archive/20250118/202501181516.o8Ibdo7z-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250118/202501181516.o8Ibdo7z-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501181516.o8Ibdo7z-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/usb/typec/ucsi/cros_ec_ucsi.c: In function 'cros_ucsi_sync_control':
>> drivers/usb/typec/ucsi/cros_ec_ucsi.c:113:15: error: too few arguments to function 'ucsi_sync_control_common'
113 | ret = ucsi_sync_control_common(ucsi, cmd);
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/usb/typec/ucsi/cros_ec_ucsi.c:20:
drivers/usb/typec/ucsi/ucsi.h:532:5: note: declared here
532 | int ucsi_sync_control_common(struct ucsi *ucsi, u64 command, u32 *cci,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/typec/ucsi/cros_ec_ucsi.c: At top level:
>> drivers/usb/typec/ucsi/cros_ec_ucsi.c:141:25: error: initialization of 'int (*)(struct ucsi *, u64, u32 *, void *, size_t)' {aka 'int (*)(struct ucsi *, long long unsigned int, unsigned int *, void *, unsigned int)'} from incompatible pointer type 'int (*)(struct ucsi *, u64)' {aka 'int (*)(struct ucsi *, long long unsigned int)'} [-Werror=incompatible-pointer-types]
141 | .sync_control = cros_ucsi_sync_control,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/usb/typec/ucsi/cros_ec_ucsi.c:141:25: note: (near initialization for 'cros_ucsi_ops.sync_control')
cc1: some warnings being treated as errors
vim +/ucsi_sync_control_common +113 drivers/usb/typec/ucsi/cros_ec_ucsi.c
f1a2241778d962 Pavan Holla 2024-12-31 107
f1a2241778d962 Pavan Holla 2024-12-31 108 static int cros_ucsi_sync_control(struct ucsi *ucsi, u64 cmd)
f1a2241778d962 Pavan Holla 2024-12-31 109 {
f1a2241778d962 Pavan Holla 2024-12-31 110 struct cros_ucsi_data *udata = ucsi_get_drvdata(ucsi);
f1a2241778d962 Pavan Holla 2024-12-31 111 int ret;
f1a2241778d962 Pavan Holla 2024-12-31 112
f1a2241778d962 Pavan Holla 2024-12-31 @113 ret = ucsi_sync_control_common(ucsi, cmd);
f1a2241778d962 Pavan Holla 2024-12-31 114 switch (ret) {
f1a2241778d962 Pavan Holla 2024-12-31 115 case -EBUSY:
f1a2241778d962 Pavan Holla 2024-12-31 116 /* EC may return -EBUSY if CCI.busy is set.
f1a2241778d962 Pavan Holla 2024-12-31 117 * Convert this to a timeout.
f1a2241778d962 Pavan Holla 2024-12-31 118 */
f1a2241778d962 Pavan Holla 2024-12-31 119 case -ETIMEDOUT:
f1a2241778d962 Pavan Holla 2024-12-31 120 /* Schedule recovery attempt when we timeout
f1a2241778d962 Pavan Holla 2024-12-31 121 * or tried to send a command while still busy.
f1a2241778d962 Pavan Holla 2024-12-31 122 */
f1a2241778d962 Pavan Holla 2024-12-31 123 cancel_delayed_work_sync(&udata->write_tmo);
f1a2241778d962 Pavan Holla 2024-12-31 124 schedule_delayed_work(&udata->write_tmo,
f1a2241778d962 Pavan Holla 2024-12-31 125 msecs_to_jiffies(WRITE_TMO_MS));
f1a2241778d962 Pavan Holla 2024-12-31 126 break;
f1a2241778d962 Pavan Holla 2024-12-31 127 case 0:
f1a2241778d962 Pavan Holla 2024-12-31 128 /* Successful write. Cancel any pending recovery work. */
f1a2241778d962 Pavan Holla 2024-12-31 129 cancel_delayed_work_sync(&udata->write_tmo);
f1a2241778d962 Pavan Holla 2024-12-31 130 break;
f1a2241778d962 Pavan Holla 2024-12-31 131 }
f1a2241778d962 Pavan Holla 2024-12-31 132
f1a2241778d962 Pavan Holla 2024-12-31 133 return ret;
f1a2241778d962 Pavan Holla 2024-12-31 134 }
f1a2241778d962 Pavan Holla 2024-12-31 135
a181c8ef0b745c Stephen Boyd 2025-01-09 136 static const struct ucsi_operations cros_ucsi_ops = {
f1a2241778d962 Pavan Holla 2024-12-31 137 .read_version = cros_ucsi_read_version,
f1a2241778d962 Pavan Holla 2024-12-31 138 .read_cci = cros_ucsi_read_cci,
f1a2241778d962 Pavan Holla 2024-12-31 139 .read_message_in = cros_ucsi_read_message_in,
f1a2241778d962 Pavan Holla 2024-12-31 140 .async_control = cros_ucsi_async_control,
f1a2241778d962 Pavan Holla 2024-12-31 @141 .sync_control = cros_ucsi_sync_control,
f1a2241778d962 Pavan Holla 2024-12-31 142 };
f1a2241778d962 Pavan Holla 2024-12-31 143
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists