linux-kernel - Re: [PATCH v2] serial: sc16is7xx: Extend IRQ check for negative values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025011855-ashen-gigantic-f832@gregkh>
Date: Sat, 18 Jan 2025 08:34:07 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Andre Werner <andre.werner@...tec-electronic.com>
Cc: jirislaby@...nel.org, hvilleneuve@...onoff.com, andy@...nel.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	lech.perczak@...lingroup.com
Subject: Re: [PATCH v2] serial: sc16is7xx: Extend IRQ check for negative
 values

On Fri, Jan 17, 2025 at 06:18:22PM +0100, Andre Werner wrote:
> Fix the IRQ check to treat the negative values as No IRQ.
> 
> Signed-off-by: Andre Werner <andre.werner@...tec-electronic.com>
> ---
> V2:
> There are no changes to the patch itself. The previous patch submission
> had a very weird structure within the discussion thread:
> https://lkml.org/lkml/2025/1/16/398
> This is simply a new thread opened for better handling.
> ---
>  drivers/tty/serial/sc16is7xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 7b51cdc274fd..560f45ed19ae 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1561,7 +1561,7 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype,
>  	/* Always ask for fixed clock rate from a property. */
>  	device_property_read_u32(dev, "clock-frequency", &uartclk);
>  
> -	s->polling = !!irq;
> +	s->polling = (irq <= 0);
>  	if (s->polling)
>  		dev_dbg(dev,
>  			"No interrupt pin definition, falling back to polling mode\n");
> -- 
> 2.48.0
> 
> 

What commit id does this "fix"?

thanks,

greg k-h