linux-kernel - Re: [PATCH v6] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMF+KebFL_9bF5UE4Pb7OQsQ6xJ6vWUXu5+4SWbnteVP_xOyaQ@mail.gmail.com>
Date: Sat, 18 Jan 2025 01:38:25 +0100
From: Joshua Grisham <josh@...huagrisham.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Joshua Grisham <josh@...huagrisham.com>, W_Armin@....de, thomas@...ch.de, 
	kuurtb@...il.com, Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org, 
	corbet@....net, linux-doc@...r.kernel.org, 
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6] platform/x86: samsung-galaxybook: Add
 samsung-galaxybook driver

Hi Ilpo!

Den fre 17 jan. 2025 kl 18:36 skrev Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com>:
>
> > +     err = devm_platform_profile_register(&galaxybook->profile_handler);
> > +     if (err)
> > +             return err;
>
> As you might already know, I've in the meantime merged the Kurt's big
> platform_profile series so these need to the be rebased on top of that.
>
> --
>  i.
>

Yes thank you! Actually I see that there is also an update to
firmware-attributes, i8042 filter, and platform_profile on for-next
that all now need to be implemented in this driver since the v6 of the
patch was posted. I have a working version drafted and will send it
shortly (along with the comment folding and spacing requests you
made).

One question and maybe more directed to Kurt regarding the new
platform_profile interface is that (similar to how I did it with the
above v6 implementation), it still feels cleanest to locally track the
different "choices" within samsung-galaxybook since it can vary
depending on the model, and this get_performance_mode_profile()
function needs to be able to evaluate during runtime what choices are
set vs not.. so in my draft for v7 I have opted to add a private data
member for platform_profile_choices and set it up during "init" of the
platform driver pretty much exactly like how is done here in v6, and
then during the new platform_profile probe I am just copying the
choices set from the private member to the choices given in the probe
callback. I hope this will make sense but please do take an extra look
at this when I post v7 and see if it looks ok or if there is a better
way to do this (again keeping in mind that setting/getting during
runtime will need to be aware of what bits were set up).

Thank you again!

Best regards,
Joshua