linux-kernel - Re: [PATCH] iio: light: apds9306: fix max_scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250118122455.54c1e96e@jic23-huawei>
Date: Sat, 18 Jan 2025 12:24:55 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>, Lars-Peter Clausen
 <lars@...afoo.de>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, stable@...r.kernel.org
Subject: Re: [PATCH] iio: light: apds9306: fix max_scale_nano values

On Sun, 12 Jan 2025 01:08:11 +0100
Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:

> The two provided max_scale_nano values must be multiplied by 100 and 10
> respectively to achieve nano units. According to the comments:
> 
> Max scale for apds0306 is 16.326432 → the fractional part is 0.326432,
> which is 326432000 in NANO. The current value is 3264320.
> 
> Max scale for apds0306-065 is 14.09721 → the fractional part is 0.09712,
> which is 97120000 in NANO. The current value is 9712000.
> 
> Update max_scale_nano initialization to use the right NANO fractional
> parts.
> 
> Cc: stable@...r.kernel.org
> Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

This just missed last pull request for this cycle.
I've locally advanced my fixes branch to include all the material that will
merge in next couple of weeks, but for now can't push it out without making
a mess of linux-next (it will be in wrong place in the sequence)

So applied, but you can't see it yet!

Jonathan

> ---
>  drivers/iio/light/apds9306.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> index 69a0d609cffc91cc3daba160f309f511270be385..5ed7e17f49e76206609aba83c85e8144c536d17d 100644
> --- a/drivers/iio/light/apds9306.c
> +++ b/drivers/iio/light/apds9306.c
> @@ -108,11 +108,11 @@ static const struct part_id_gts_multiplier apds9306_gts_mul[] = {
>  	{
>  		.part_id = 0xB1,
>  		.max_scale_int = 16,
> -		.max_scale_nano = 3264320,
> +		.max_scale_nano = 326432000,
>  	}, {
>  		.part_id = 0xB3,
>  		.max_scale_int = 14,
> -		.max_scale_nano = 9712000,
> +		.max_scale_nano = 97120000,
>  	},
>  };
>  
> 
> ---
> base-commit: 577a66e2e634f712384c57a98f504c44ea4b47da
> change-id: 20241218-apds9306_nano_vals-d880219a82f2
> 
> Best regards,