linux-kernel - Re: 6.1.125 build fail was -- Re: [PATCH 6.1 00/92] 6.1.125-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c0f0a12-a65b-4b79-bea9-cda35f8f5caf@w6rz.net>
Date: Sat, 18 Jan 2025 04:27:34 -0800
From: Ron Economos <re@...z.net>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Pavel Machek <pavel@...x.de>, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: 6.1.125 build fail was -- Re: [PATCH 6.1 00/92] 6.1.125-rc1
 review

On 1/17/25 23:20, Greg Kroah-Hartman wrote:
> On Fri, Jan 17, 2025 at 10:37:03PM -0800, Ron Economos wrote:
>> On 1/17/25 13:16, Pavel Machek wrote:
>>> Hi!
>>>
>>>>>> Still building, but we already have failures on risc-v.
>>>>>>
>>>>>> drivers/usb/core/port.c: In function 'usb_port_shutdown':
>>>>>> 2912
>>>>>> drivers/usb/core/port.c:417:26: error: 'struct usb_device' has no member named 'port_is_suspended'
>>>>>> 2913
>>>>>>     417 |         if (udev && !udev->port_is_suspended) {
>>>>>> 2914
>>>>>>         |                          ^~
>>>>>> 2915
>>>>>> make[4]: *** [scripts/Makefile.build:250: drivers/usb/core/port.o] Error 1
>>>>>> 2916
>>>>>> make[4]: *** Waiting for unfinished jobs....
>>>>>> 2917
>>>>>>     CC      drivers/gpu/drm/radeon/radeon_test.o
>>>>> And there's similar failure on x86:
>>>>>
>>>>> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/1626266073
>>>> Thanks for testing and letting me know,
>>> Ok, so it seems _this_ failure is fixed... but there's new one. Build
>>> failure on risc-v.
>>>
>>>     LD      .tmp_vmlinux.kallsyms1
>>> 2941
>>> riscv64-linux-gnu-ld: drivers/usb/host/xhci-pci.o: in function `xhci_pci_resume':
>>> 2942
>>> xhci-pci.c:(.text+0xd8c): undefined reference to `xhci_resume'
>>> 2943
>>> riscv64-linux-gnu-ld: xhci-pci.c:(.text+0xe1a): undefined reference to `xhci_suspend'
>>> 2944
>>> make[1]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1
>>> 2945
>>> make: *** [Makefile:1250: vmlinux] Error 2
>>>
>>> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/8883180471
>>>
>>> (I have also 2 runtime failures, I'm retrying those jobs.
>>>
>>> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/1630005263
>>>
>>> ). I partly reconsructed To:.
>>>
>>> Best regards,
>>>
>>> 								Pavel
>> Seeing the build failure on RISC-V here also. The fixup patch was a little
>> too aggressive. I tried just removing the #ifdef CONFIG_PM around
>> "port_is_suspended" in include/linux/usb.h and it builds okay.
> Can you send a fix-up patch for this that works for you?
>
> thanks,
>
> greg k-h

I just sent a patch. 
https://lore.kernel.org/linux-kernel/20250118122409.4052121-1-re@w6rz.net/

I'm not used to sending patches, so I hope it's okay.