linux-kernel - Re: [RFC PATCH v1 0/6] rockchip: add a functional usb3 phy driver for rk3328

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMdYzYoE54PSdTH9JPBFLggDy9CZsj47N6qFKJFZz4xe3VVbBw@mail.gmail.com>
Date: Sat, 18 Jan 2025 09:35:08 -0500
From: Peter Geis <pgwipeout@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Heiko Stuebner <heiko@...ech.de>, zyw@...k-chips.com, kever.yang@...k-chips.com, 
	frank.wang@...k-chips.com, william.wu@...k-chips.com, wulf@...k-chips.com, 
	linux-rockchip@...ts.infradead.org, Alex Bee <knaerzche@...il.com>, 
	Algea Cao <algea.cao@...k-chips.com>, Arnd Bergmann <arnd@...db.de>, 
	Conor Dooley <conor+dt@...nel.org>, Cristian Ciocaltea <cristian.ciocaltea@...labora.com>, 
	Diederik de Haas <didi.debian@...ow.org>, Dragan Simic <dsimic@...jaro.org>, 
	Elaine Zhang <zhangqing@...k-chips.com>, FUKAUMI Naoki <naoki@...xa.com>, 
	Johan Jonker <jbx6244@...il.com>, Jonas Karlman <jonas@...boo.se>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Michael Turquette <mturquette@...libre.com>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Rob Herring <robh@...nel.org>, Sebastian Reichel <sebastian.reichel@...labora.com>, 
	Stephen Boyd <sboyd@...nel.org>, Trevor Woerner <twoerner@...il.com>, Vinod Koul <vkoul@...nel.org>, 
	Zhang Yubing <yubing.zhang@...k-chips.com>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org
Subject: Re: [RFC PATCH v1 0/6] rockchip: add a functional usb3 phy driver for rk3328

On Sat, Jan 18, 2025 at 4:08 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 15/01/2025 02:26, Peter Geis wrote:
> >
> > This is my newly reworked phy driver for the rk3328 usb3 phy. It is
> > based loosely on my original version, but as of now almost nothing of
> > the original driver remains. The main fix here is the discovery of
> > BIT(6) in the interrupt enable grf register fixes the usb3 disconnection
> > detection (mostly). On occasion an unpopulated usb3 hub will take
> > several seconds to disconnect. However this means all of the hack around
> > work to reset the usb core manually is no longer required.
> >
> BTW, RFC for some maintainers means "do not review, work-in-progress".
> For some means "review, but low priority" or "review, but for sure I
> have bugs here". I usually review and then someone responds: "it is not
> for review, it is just RFC", so to avoid my wasted time please always
> mention in cover letter why this is RFC. What do you expect here or why
> this is not ready for review as normal patch.

Thank you, that makes sense. I marked it as RFC as I'm aware it isn't
a perfect solution and there's a lot of undefined values. What I was
looking for here was:
- Review for code quality, so if I'm completely off track I can get to
work fixing it. (Thank you so far)
- Sanity testing from others struggling with the issues it fixes.
- Feedback from USB engineers about the issues remaining.
- Hopefully someone with access to the IP can provide insight into the
magic registers.

>
> Best regards,
> Krzysztof