linux-kernel - Re: [PATCH v4 0/2] iio: adc: ad7173: fix non-const info struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250118151735.560fdb03@jic23-huawei>
Date: Sat, 18 Jan 2025 15:17:35 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Dumitru Ceclan <mitrutzceclan@...il.com>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Nuno Sa <nuno.sa@...log.com>, Michael Walle
 <michael@...le.cc>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Uwe
 Kleine-König <u.kleine-koenig@...libre.com>, Guillaume
 Ranquet <granquet@...libre.com>
Subject: Re: [PATCH v4 0/2] iio: adc: ad7173: fix non-const info struct

On Mon, 13 Jan 2025 15:43:17 -0600
David Lechner <dlechner@...libre.com> wrote:

> While working ad7124, Uwe pointed out a bug in the ad7173 driver.
> static struct ad_sigma_delta_info ad7173_sigma_delta_info was not const
> and was being modified during driver probe, which could lead to race
> conditions if two instances of the driver were probed at the same time.
> 
> The fix from v2 has already been picked up, so these are the remaining
> patches that can now be applied since the fix has made it's way back
> into the iio/togreg branch.
Looks good to me, so I've applied it to the testing branch of iio.git
to get some build coverage etc.
> 
> Guillaume, since there were significant changes in this revision, it
> would be nice if you could test again.
I'm happy to rebase until after rc1 so plenty of time for this.

Jonathan

> 
> ---
> Changes in v4:
> - Replaced patch that removes irq_line field with a different approach
>   that still looks up the IRQ by name.
> - Link to v3: https://lore.kernel.org/r/20250110-iio-adc-ad7313-fix-non-const-info-struct-v3-0-41e1c9cdd1a7@baylibre.com
> 
> Changes in v3:
> - Dropped first patch that was already applied.
> - Fixed compile error due to spurious rebasing artifact.
> - Rebased on top of latest iio tree and resolved conflicts.
> - Link to v2: https://lore.kernel.org/r/20241127-iio-adc-ad7313-fix-non-const-info-struct-v2-0-b6d7022b7466@baylibre.com
> 
> Changes in v2:
> - Fixed chip name in a few places.
> - Add new simpler patch for "fix" that gets backported.
> - Rebase other patches on this and incorporate feedback.
> - Link to v1: https://lore.kernel.org/r/20241122-iio-adc-ad7313-fix-non-const-info-struct-v1-0-d05c02324b73@baylibre.com
> 
> ---
> David Lechner (2):
>       iio: adc: ad7173: move fwnode_irq_get_byname() call site
>       iio: adc: ad7173: don't make copy of ad_sigma_delta_info struct
> 
>  drivers/iio/adc/ad7173.c               | 489 +++++++++++++++++----------------
>  drivers/iio/adc/ad_sigma_delta.c       |  11 +-
>  include/linux/iio/adc/ad_sigma_delta.h |   4 +-
>  3 files changed, 266 insertions(+), 238 deletions(-)
> ---
> base-commit: 56ea2bb4297338aa1c185696b287d384ec27c0d4
> change-id: 20241122-iio-adc-ad7313-fix-non-const-info-struct-92e59b91ee2e
> 
> Best regards,