Message-ID: <20250118171751.4d966c98@jic23-huawei>
Date: Sat, 18 Jan 2025 17:17:51 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
Cc: Matti Vaittinen <mazziesaccount@...il.com>, Matti Vaittinen
 <matti.vaittinen@...rohmeurope.com>, Lars-Peter Clausen <lars@...afoo.de>,
 Mudit Sharma <muditsharma.info@...il.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: gts: Simplify available scale table build

On Sat, 11 Jan 2025 12:42:24 +0000
Jonathan Cameron <jic23@...nel.org> wrote:

> On Sat, 11 Jan 2025 14:47:28 +1030
> Subhajit Ghosh <subhajit.ghosh@...aklogic.com> wrote:
> 
> > On 11/1/25 00:56, Matti Vaittinen wrote:  
> > > On 22/12/2024 11:24, Matti Vaittinen wrote:    
> > >> On 20/12/2024 21:21, Jonathan Cameron wrote:    
> > >>> On Mon, 16 Dec 2024 10:56:37 +0200
> > >>> Matti Vaittinen <mazziesaccount@...il.com> wrote:
> > >>>    
> > >>>> Make available scale building more clear. This hurts the performance
> > >>>> quite a bit by looping throgh the scales many times instead of doing
> > >>>> everything in one loop. It however simplifies logic by:
> > >>>>   - decoupling the gain and scale allocations & computations
> > >>>>   - keeping the temporary 'per_time_gains' table inside the
> > >>>>     per_time_scales computation function.
> > >>>>   - separating building the 'all scales' table in own function and doing
> > >>>>     it based on the already computed per-time scales.
> > >>>>
> > >>>> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>    
> > >>> Looks good to me, but I want to leave it on list a while before applying.
> > >>> Ideal if it gets some tested-by or other tags before I pick it up.
> > >>> As always, this is fiddly code, so the more eyes the better!    
> > >>
> > >> Please, let it wait until the Christmas has passed. I got information we might be getting some testing before the year changes :)    
> > > 
> > > Well, the year changed and no tested-by tags emerged. I suppose my sources weren't right at this time.
> > > 
> > > Yours,
> > >      -- Matti    
> > Hi Matti,
> > 
> > Hope you had a good Christmas and new year. After my US trip, it took me some time
> > to come to terms that I have to work for a living!
> > 
> > The code works fine. I tested it with apds9306 driver with stm32mp157-dk2 board.
> > 
> > Tested-by: subhajit.ghosh@...aklogic.com
> > 
> > Just want to report something else which may not be related to this.
> > When I tried to cross-compile with linux-gnueabi-gcc version 12.2.0 with Linux kernel 6.1.28, I got the following errors:
> >    CC [M]  /home/subhajit/opensource_contributions/apds9306/apds9306_backport/./drivers/iio/industrialio-gts-helper.o
> > /tmp/ccn9UpwF.s: Assembler messages:
> > /tmp/ccn9UpwF.s:22: Error: junk at end of line, first unrecognized character is `I'
> > ...
> > ...
> > 
> > I had to remove the double quotes from the macros for all symbol exports:
> > EXPORT_SYMBOL_NS_GPL(iio_gts_total_gain_to_scale, "IIO_GTS_HELPER");
> > to
> > EXPORT_SYMBOL_NS_GPL(iio_gts_total_gain_to_scale, IIO_GTS_HELPER);
> > 
> > However the x86_64 native build of the mainline kernel 6.13.0-rc6 on my laptop went just fine with this patch.
> > 
> > Regards,
> > Subhajit Ghosh  
> 
> Hi Subhajit,
> 
> You've run into a tree wide change wrt to those quote that went in just after rc1 of this cycle.
> The error message is less than helpful and we've spent all cycle fixing these up :(
> 
> Anyhow this is expected if backporting.
> 
> Jonathan
> 
Applied to the testing branch of iio.git. I'll be rebasing on rc1 once it
is available and then push this out as normal togreg branch.

Thanks

Jonathan

> 
> 

Powered by blists - more mailing lists