linux-kernel - Re: [PATCH] dmaengine: idxd: Delete unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bad17290-10bf-f162-c49a-4822335bb9a7@intel.com>
Date: Fri, 17 Jan 2025 16:17:28 -0800
From: Fenghua Yu <fenghua.yu@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Dave Jiang <dave.jiang@...el.com>, Vinod Koul <vkoul@...nel.org>,
	<dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: idxd: Delete unnecessary NULL check



On 1/8/25 01:13, Dan Carpenter wrote:
> The "saved_evl" pointer is a offset into the middle of a non-NULL struct.
> It can't be NULL and the check is slightly confusing.  Delete the check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>

> ---
>   drivers/dma/idxd/init.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index b946f78f85e1..fca1d2924999 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -912,8 +912,7 @@ static void idxd_device_config_restore(struct idxd_device *idxd,
>   
>   	idxd->rdbuf_limit = idxd_saved->saved_idxd.rdbuf_limit;
>   
> -	if (saved_evl)
> -		idxd->evl->size = saved_evl->size;
> +	idxd->evl->size = saved_evl->size;
>   
>   	for (i = 0; i < idxd->max_groups; i++) {
>   		struct idxd_group *saved_group, *group;

Thanks.

-Fenghua