linux-kernel - Re: [PATCH][next] net/mlx5: fix unintentional sign extension on shift of dest_attr->vport.vhca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173717283499.2332438.5321768112783382973.git-patchwork-notify@kernel.org>
Date: Sat, 18 Jan 2025 04:00:34 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Colin Ian King <colin.i.king@...il.com>
Cc: saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, moshe@...dia.com, kliteyn@...dia.com,
 mbloch@...dia.com, netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net/mlx5: fix unintentional sign extension on shift of
 dest_attr->vport.vhca_id

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 16 Jan 2025 18:17:00 +0000 you wrote:
> Shifting dest_attr->vport.vhca_id << 16 results in a promotion from an
> unsigned 16 bit integer to a 32 bit signed integer, this is then sign
> extended to a 64 bit unsigned long on 64 bitarchitectures. If vhca_id is
> greater than 0x7fff then this leads to a sign extended result where all
> the upper 32 bits of idx are set to 1. Fix this by casting vhca_id
> to the same type as idx before performing the shift.
> 
> [...]

Here is the summary with links:
  - [next] net/mlx5: fix unintentional sign extension on shift of dest_attr->vport.vhca_id
    https://git.kernel.org/netdev/net-next/c/41c5d104f338

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html