linux-kernel - Re: [PATCH net-next v4 5/6] net: xilinx: axienet: Get coalesce parameters from driver state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250118171838.215e58ec@kernel.org>
Date: Sat, 18 Jan 2025 17:18:38 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Radhey Shyam Pandey
 <radhey.shyam.pandey@....com>, netdev@...r.kernel.org, Michal Simek
 <michal.simek@....com>, linux-kernel@...r.kernel.org, Shannon Nelson
 <shannon.nelson@....com>, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v4 5/6] net: xilinx: axienet: Get coalesce
 parameters from driver state

On Thu, 16 Jan 2025 18:29:53 -0500 Sean Anderson wrote:
> +/**
> + * axienet_cr_params() - Extract coalesce parameters from the CR
> + * @lp: Device private data
> + * @cr: The control register to parse
> + * @count: Number of packets before an interrupt
> + * @usec: Idle time (in usec) before an interrupt
> + */
> +static void axienet_coalesce_params(struct axienet_local *lp, u32 cr,
> +				    u32 *count, u32 *usec)

W=1 builds hit:

drivers/net/ethernet/xilinx/xilinx_axienet_main.c:277: warning: expecting prototype for axienet_cr_params(). Prototype was for axienet_coalesce_params() instead

I'll apply the first 2 patches, 2nd one is almost a fix..
The rest may need to wait until after the merge window, unless Linus
tags -rc8.