linux-kernel - drivers/gpu/drm/scheduler/sched_main.c:405: warning: Function parameter or struct member 'result' not described in 'drm_sched_job

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202501200535.SBTvzNWJ-lkp@intel.com>
Date: Mon, 20 Jan 2025 05:32:45 +0800
From: kernel test robot <lkp@...el.com>
To: Matthew Brost <matthew.brost@...el.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Rodrigo Vivi <rodrigo.vivi@...el.com>
Subject: drivers/gpu/drm/scheduler/sched_main.c:405: warning: Function
 parameter or struct member 'result' not described in 'drm_sched_job_done'

Hi Matthew,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9528d418de4d83c7ada69314ddd8d4427b1f703a
commit: dd08ebf6c3525a7ea2186e636df064ea47281987 drm/xe: Introduce a new DRM driver for Intel GPUs
date:   1 year, 1 month ago
config: i386-randconfig-011-20240921 (https://download.01.org/0day-ci/archive/20250120/202501200535.SBTvzNWJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250120/202501200535.SBTvzNWJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501200535.SBTvzNWJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/scheduler/sched_main.c:405: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done'


vim +405 drivers/gpu/drm/scheduler/sched_main.c

f7fe64ad0f22ff Matthew Brost    2023-10-30  397  
71173e787cab9d Luben Tuikov     2020-12-03  398  /**
71173e787cab9d Luben Tuikov     2020-12-03  399   * drm_sched_job_done - complete a job
71173e787cab9d Luben Tuikov     2020-12-03  400   * @s_job: pointer to the job which is done
71173e787cab9d Luben Tuikov     2020-12-03  401   *
71173e787cab9d Luben Tuikov     2020-12-03  402   * Finish the job's fence and wake up the worker thread.
71173e787cab9d Luben Tuikov     2020-12-03  403   */
539f9ee4b52a8b Christian König  2023-04-17  404  static void drm_sched_job_done(struct drm_sched_job *s_job, int result)
71173e787cab9d Luben Tuikov     2020-12-03 @405  {
71173e787cab9d Luben Tuikov     2020-12-03  406  	struct drm_sched_fence *s_fence = s_job->s_fence;
71173e787cab9d Luben Tuikov     2020-12-03  407  	struct drm_gpu_scheduler *sched = s_fence->sched;
71173e787cab9d Luben Tuikov     2020-12-03  408  
a78422e9dff366 Danilo Krummrich 2023-11-10  409  	atomic_sub(s_job->credits, &sched->credit_count);
f2f12eb9c32bc7 Christian König  2021-02-02  410  	atomic_dec(sched->score);
71173e787cab9d Luben Tuikov     2020-12-03  411  
71173e787cab9d Luben Tuikov     2020-12-03  412  	trace_drm_sched_process_job(s_fence);
71173e787cab9d Luben Tuikov     2020-12-03  413  
71173e787cab9d Luben Tuikov     2020-12-03  414  	dma_fence_get(&s_fence->finished);
539f9ee4b52a8b Christian König  2023-04-17  415  	drm_sched_fence_finished(s_fence, result);
71173e787cab9d Luben Tuikov     2020-12-03  416  	dma_fence_put(&s_fence->finished);
67dd1d8c9f6543 Tvrtko Ursulin   2023-11-02  417  	__drm_sched_run_free_queue(sched);
71173e787cab9d Luben Tuikov     2020-12-03  418  }
71173e787cab9d Luben Tuikov     2020-12-03  419  

:::::: The code at line 405 was first introduced by commit
:::::: 71173e787cab9db4ca1fa6229477cb3d254bc285 drm/scheduler: Essentialize the job done callback

:::::: TO: Luben Tuikov <luben.tuikov@....com>
:::::: CC: Christian König <christian.koenig@....com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki