linux-kernel - Re: [External Email] Re: [PATCH v2] serial: sc16is7xx: Extend IRQ check for negative values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025011924-circle-iron-5d09@gregkh>
Date: Sun, 19 Jan 2025 07:48:40 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Andre Werner <andre.werner@...tec-electronic.com>
Cc: jirislaby@...nel.org, hvilleneuve@...onoff.com, andy@...nel.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	lech.perczak@...lingroup.com
Subject: Re: [External Email] Re: [PATCH v2] serial: sc16is7xx: Extend IRQ
 check for negative values

On Sat, Jan 18, 2025 at 08:28:49PM +0100, Andre Werner wrote:
> Dear Greg,
> 
> > On Fri, Jan 17, 2025 at 06:18:22PM +0100, Andre Werner wrote:
> > > Fix the IRQ check to treat the negative values as No IRQ.
> > >
> > > Signed-off-by: Andre Werner <andre.werner@...tec-electronic.com>
> > > ---
> > > V2:
> > > There are no changes to the patch itself. The previous patch submission
> > > had a very weird structure within the discussion thread:
> > > https://lkml.org/lkml/2025/1/16/398
> > > This is simply a new thread opened for better handling.
> > > ---
> > >  drivers/tty/serial/sc16is7xx.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> > > index 7b51cdc274fd..560f45ed19ae 100644
> > > --- a/drivers/tty/serial/sc16is7xx.c
> > > +++ b/drivers/tty/serial/sc16is7xx.c
> > > @@ -1561,7 +1561,7 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype,
> > >  	/* Always ask for fixed clock rate from a property. */
> > >  	device_property_read_u32(dev, "clock-frequency", &uartclk);
> > >
> > > -	s->polling = !!irq;
> > > +	s->polling = (irq <= 0);
> > >  	if (s->polling)
> > >  		dev_dbg(dev,
> > >  			"No interrupt pin definition, falling back to polling mode\n");
> > > --
> > > 2.48.0
> > >
> > >
> >
> > What commit id does this "fix"?
> 
> 104c1b9dde9d859dd01bd2d71a2755a2fae43e15
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?h=tty-next&id=104c1b9dde9d859dd01bd2d71a2755a2fae43e15
> 

Great, then properly document that with a Fixes: tag when you resend
this please.

thanks,

greg k-h