linux-kernel - Re: [PATCH] ASoC: audio-graph-card2: use correct endpoint when getting link parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h65t3voj.wl-kuninori.morimoto.gx@renesas.com>
Date: Mon, 20 Jan 2025 23:35:56 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
Cc: Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: audio-graph-card2: use correct endpoint when getting link parameters


Hi Ivaylo

Thank you for the patch

> When link DT nodes are parsed, most functions get port as a parameter,
> which results in port endpoint@0 always being used. However, each endpoint
> might have different settings, but those are currently ignored.
> 
> Fix that by passing endpoint instead of port when parsing link parameters.
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
> ---
(snip)
> @@ -831,9 +830,8 @@ int audio_graph2_link_normal(struct simple_util_priv *priv,
>  			     struct device_node *lnk,
>  			     struct link_info *li)
>  {
> -	struct device_node *cpu_port = lnk;
> -	struct device_node *cpu_ep	__free(device_node) = of_graph_get_next_port_endpoint(cpu_port, NULL);
> -	struct device_node *codec_port	__free(device_node) = of_graph_get_remote_port(cpu_ep);
> +	struct device_node *cpu_ep __free(device_node) = of_graph_get_next_port_endpoint(lnk, NULL);
> +	struct device_node *codec_ep __free(device_node) = of_graph_get_remote_endpoint(cpu_ep);
>  	int ret;

You don't need to change cpu_port/cpu_ep here ?
And, I would like to keep "cpu_port = lnk" here.

Except above
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto