linux-kernel - Re: [PATCH] MIPS: Loongson64: env: Use str_on_off() helper in prom_lefi_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z46m6MHmRMfUnVrD@alpha.franken.de>
Date: Mon, 20 Jan 2025 20:41:28 +0100
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Huacai Chen <chenhuacai@...nel.org>,
	Jiaxun Yang <jiaxun.yang@...goat.com>, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Loongson64: env: Use str_on_off() helper in
 prom_lefi_init_env()

On Wed, Jan 15, 2025 at 10:01:35AM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_on_off() helper function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  arch/mips/loongson64/env.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/loongson64/env.c b/arch/mips/loongson64/env.c
> index 09ff05269861..be8d2ad10750 100644
> --- a/arch/mips/loongson64/env.c
> +++ b/arch/mips/loongson64/env.c
> @@ -17,6 +17,7 @@
>  #include <linux/dma-map-ops.h>
>  #include <linux/export.h>
>  #include <linux/pci_ids.h>
> +#include <linux/string_choices.h>
>  #include <asm/bootinfo.h>
>  #include <loongson.h>
>  #include <boot_param.h>
> @@ -162,7 +163,7 @@ void __init prom_lefi_init_env(void)
>  		dma_default_coherent = !eirq_source->dma_noncoherent;
>  	}
>  
> -	pr_info("Firmware: Coherent DMA: %s\n", dma_default_coherent ? "on" : "off");
> +	pr_info("Firmware: Coherent DMA: %s\n", str_on_off(dma_default_coherent));
>  
>  	loongson_sysconf.restart_addr = boot_p->reset_system.ResetWarm;
>  	loongson_sysconf.poweroff_addr = boot_p->reset_system.Shutdown;
> -- 
> 2.47.1

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]