linux-kernel - Re: [PATCH 2/3] perf: Fix low freq setting via IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fa8372e-41d2-4b0d-a549-cff9ab208bf2@amd.com>
Date: Mon, 20 Jan 2025 10:29:14 +0530
From: Ravi Bangoria <ravi.bangoria@....com>
To: kan.liang@...ux.intel.com, peterz@...radead.org, mingo@...hat.com,
 acme@...nel.org, namhyung@...nel.org, irogers@...gle.com,
 linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Cc: ak@...ux.intel.com, jolsa@...hat.com, stable@...r.kernel.org,
 Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH 2/3] perf: Fix low freq setting via IOC_PERIOD

On 17-Jan-25 8:49 PM, kan.liang@...ux.intel.com wrote:
> From: Kan Liang <kan.liang@...ux.intel.com>
> 
> A low freq cannot be set via IOC_PERIOD on some platforms.
> 
> The perf_event_check_period() introduced in commit 81ec3f3c4c4d
> ("perf/x86: Add check_period PMU callback") intended to check the
> period, rather than the freq. A low freq may be mistakenly rejected by
> the limit_period().
> 
> Fixes: 81ec3f3c4c4d ("perf/x86: Add check_period PMU callback")
> Closes: https://lore.kernel.org/lkml/20250115154949.3147-1-ravi.bangoria@amd.com/
> Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Ravi Bangoria <ravi.bangoria@....com>
> Cc: stable@...r.kernel.org

Reviewed-by: Ravi Bangoria <ravi.bangoria@....com>

Thanks,
Ravi